tynet-lichat/shirakumo - IRC Chatlog
Search
15:13:34
|3b|
shinmera: having a structs+single-floats fast path is good, i'll need to review code and think a bit to decide if i think that should be the only API or not though
15:18:03
|3b|
no idea on that, seem to remember some of that being confusing about which data was coming from where, but if it is demonstrably broken fixes are probably good?
15:21:01
shinmera
I assume you're using them from the font generator and just passing plists in there rather than constructing font objects
15:24:40
shinmera
Anyway, I'll update everything to use the class/sruct for consistency and will PR, probably tomorrow.
15:26:24
|3b|
looks like there is at least 1 other user of 3b-bmfont, so i might add a compatibility layer with old API (should be pretty trivial to translate the data anyway)
15:26:51
shinmera
are you sure you want to add compatibility now already when the api isn't even pretend-stable? :u
15:27:46
shinmera
Personally I'd rather break and PR the other project to fix, than add compatibility crust.
15:28:46
|3b|
if there were any reasonable way to communicate changes to users before making big changes i'd consider it, but "unchanged and usable for years" seems to counter the "not claimed to be stable" part a bit to me
15:29:53
|3b|
ACTION found 2 on github, 2 (probably abandoned, but still..) mirrored on gh from elsewhere, 1 more on GH considering it
15:30:59
|3b|
ACTION can fix 1 of the 2 active ones, and author of other is on irc so probably could coordinate fixes, but still evidence that there might be more elsewhere
15:32:05
|3b|
ACTION might also go too far in the direction of "don't break things", but i still prefer to go too far that way than the other way :)
15:35:52
|3b|
i guess there has been an issue open to "get rid of plists" for half a year with no objections, so maybe
15:53:05
|3b|
i suspect it is generating invalid bmfont files, and probably should be doing some coercing to floats before saving (or not generating non-integer values in general)
15:53:43
shinmera
how do you feel about the other glyph fields? should they stay integers or should they all just be single-floats?
15:53:45
|3b|
though if bmfont is suppose to be integer only, i do want the ability to have float offsets and sizes eventually anyway
15:55:10
|3b|
though possibly places where we generate rationals should be generating larger ints and using another field as a global divisor
15:56:43
|3b|
plenty of fraction bits left in 24 bits if we want to do subtexel positions in a 4k texture for example
15:57:55
|3b|
ACTION should find whatever is generating x/10 and make it generate x/8 or x/16 either way :p