tynet-lichat/shirakumo - IRC Chatlog
Search
Saturday, 24th of September 2022, 22:33:00 UTC
22:43:50
|3b|
any reason for doing `loop for i = read then (1+ i) while (< i write)...` instead of `loop for i from read below write...`?
22:44:26
|3b|
queue-discard, discard-events
22:44:56
shinmera
probably used to re-read pointers before I set it back.
22:46:42
shinmera
as in, it would re-read the limits each iteration or something. Dunno. As is, a for from would be better, yes.
22:51:34
|3b|
should elements and reallocating slots have type (or null simple-vector)?
22:52:06
|3b|
or should reallocating be initialized in make-queue?
22:52:15
|3b|
because NIL isn't a simple-vector?
22:52:40
|3b|
ah, sorry, missed the :constructor
22:53:08
shinmera
the reallocating buffer should be the same as the elements buffer when no reallocation is going on.
22:53:17
|3b|
(and probably read `elements elements` as `:elements elements` or something)
22:53:40
shinmera
No problem. I... didn't exactly comment on my thought process.
22:57:34
|3b|
"Accessing whether a set is active or not imply happens with ``active-p``." probably has a typo, but also possibly should be rewritten instead of having typo fixed :)
9:06:01
Colleen
Shinmera: for zippy, do you prefer a single pull request with one commits for each change or a separate pull request for each change?
9:06:01
scymtym
Shinmera: for zippy, do you prefer a single pull request with one commits for each change or a separate pull request for each change?
Sunday, 25th of September 2022, 10:33:00 UTC