3:28:35
|3b|
shinmera: hmm, i think mmap should be closing the handle from create-file-mapping in addition to the one from create-file
3:29:38
|3b|
do you think it would be reasonable to return (list fd handle) in place of fd from %mmap, or should it add another return value
3:30:36
|3b|
(symptom i see from not doing that is that after i read a png from lisp, i can't overwrite it from an external program)
3:31:38
|3b|
probably should also close both in the error path at end of %mmap as well
3:36:17
|3b|
looks like docs say "opaque file descriptor, don't touch it" so returning a list for FD is possibly reasonable?
3:41:26
|3b|
ah, i guess you already did that :p
3:41:32
|3b|
ACTION was pulling wrong repo :/
3:46:33
|3b|
yeah, works as expected with current code
6:05:38
shinmera
Hooray for fixes where I don't have to do anything