tynet-lichat/shirakumo - IRC Chatlog
Search
12:28:25
Gleefre
re kandria: the latest trial change fixed the up/down keys moving the cursor by two (it actually moved by 2 for a keypress and by 1 more when the key released; although that's not important). The options / mods tab view not closing seems to be because of the change to the alloy:exit observable, now only triggering for the component class; while kandria uses it on a focus-element (superclass of component). If I remove (:class component), I also need to add a NIL check for the focus-element's exit method on the focus-tree field (I think kandria's observer on the focus-element hides it, removing it from the focus tree? or something like that anyways). This is probably not quite the correct fix anyways.
12:34:19
Gleefre
A couple more obvious bugs from playing the game: dialogues seem not to render, unless I resize the screen and then the current npc line becomes visible, and it gets stuck on that instead of an empty dialogue box (not sure what's up with that). And when the game is finished, the stats calculation breaks on the lore-find-rate function due to not yet finalized classes (so this is probably only a problem if you are running from source, as deploy/trial likely finalizes all classes before saving an image..), on which c2mop:class-prototype signals an error.
12:35:25
Gleefre
So would need to change to :class focus-element or something like that then? (https://codeberg.org/shirakumo/alloy/src/branch/master/component.lisp#L74-L75 -- and there is also activate there, not sure if it is in the same group as exit or not)
12:38:25
Gleefre
I think it would still error in kandria on the exit method for focus-element where it does `(focused (focus-tree element))`, since it's a :before observable and it does `(hide panel)` inside of it, which I assume removes it from the focus-tree and you end up calling `(focused nil)`
12:43:43
Gleefre
`(:class focus-element)` for (setf focus) maybe needs to be after the class definition? Uh, though not sure, maybe I just messed up my local changes to the observables library.
13:22:37
Colleen
Shinmera: not sure about hooking up actions. i will let you know later. a possibly independent thing i noticed was that C-f matched the actions for C-f as well as C-S-f. if i recall correctly, those are search forward and search backwards
13:22:37
scymtym
Shinmera: not sure about hooking up actions. i will let you know later. a possibly independent thing i noticed was that C-f matched the actions for C-f as well as C-S-f. if i recall correctly, those are search forward and search backwards
13:28:12
Colleen
there could be some remnants of action-related changes in the branch which cause this. i haven't had time to test with master
13:28:12
scymtym
there could be some remnants of action-related changes in the branch which cause this. i haven't had time to test with master
13:28:58
shinmera
I'm currently going through all the tickets callie reported that are well within my purview
13:32:14
Colleen
thanks. i always want to look at those but then there is something immediate to fix
13:32:14
scymtym
thanks. i always want to look at those but then there is something immediate to fix
13:38:34
Gleefre
oh I just saw you fixed values changing on non-strong focus on a wheel component; I think the same needs to be done for the slider as well? (that's one of the bugs in kandria I wanted to debug at some point x.x)
13:39:48
Gleefre
or at least it seems to be a half of a fix for kandria -- it still increments the value twice when you press left/right under strong focus (but only once for up/down)...
14:20:02
shinmera
okey, I've fixed a bunch of stuff now, too tired to continue, and some things I'm not sure if they're due to notice-size not propagating or other text related issues
14:53:16
Hugo
I've solved an issue I was having with CharMorph. It works well with Trial and opensource too.