libera/#sicl - IRC Chatlog
Search
19:39:43
scymtym
Bike: i came up with yet another (the third, i think) solution for the NIL-as-eof-value issue: https://github.com/s-expressionists/Eclector/compare/master...end-of-input-fix . compared to the second(?) solution, this one avoids introducing yet another magic value
19:39:51
scymtym
i also took the opportunity to document the differences in terms of returns values between "CL mode" and "parse result mode". does this look OK to you?
19:43:24
Bike
documenting the additional values thing is definitely good. seems like something eclector does in a few places.
19:48:21
Bike
you could use m-v-call instead of dest-bind and m-v-list to maybe save some consing, but that's a nitpick
19:54:22
scymtym
thanks. i think i considered that but didn't see how to examine the return value count, but let me check again
19:56:29
Bike
(multiple-value-call (lambda (value &optional (parse-result nil parse-result-p)) ...) (call-next-method)) would do it i think
19:58:24
Bike
it's a bit uglier than the dest-bind, maybe, but after spending time implementing multiple-value-call i kind of want to see it used to its full potential, eheh
20:24:39
scymtym
the difference in terms of consing and runtime is quite significant as well. at least in a micro-benchmark in SBCL