libera/#sicl - IRC Chatlog
Search
18:47:42
paulapatience
Bike: I did update it, but it's part of my larger PR. You can update it separately, and I will adjust
18:49:52
Bike
paulapatience: if you have a PR for cleavir, could you submit it as a draft so I can take a gander?
18:51:39
paulapatience
Sure, I'll do that tonight. I could also submit the reconstruct PR if you want.
0:42:40
paulapatience
Bike: Trucler draft PR submitted. I explained the state of the PR in the conversation.
0:50:29
paulapatience
I will also fix the bad call to DISJUNCTIONP. Makes more sense to keep it separate if I'm submitting several PRs anyway.
2:53:16
paulapatience
Bike: You said cleavir-compilation-policy doesn't need to depend on the environment. It calls cleavir-environment:optimize-qualities in normalize-optimize, though, and optimize-qualities's only argument is environment. Does it still need environment? If it does, then we can't really remove environment from cleavir-compilation-policy. It doesn't seem right to move optimize-qualities to cst-to-ast, because the latter is not depended upon by
3:08:53
Bike
optimize-qualities should probably also use the client instead of the environment, actually
3:10:34
Bike
if you don't know, the optimize-qualities is the set of well, optimize qualities. like speed and space and all, i think. so that is (conceptually) fixed by the client rather than the environment
3:13:02
paulapatience
Well, I was seeing the SBCL implementation of cleavir-environment, and it seems to be using the environment
3:14:42
Bike
so it is, but it doesn't actually use any of the optimize info, so it's fine. also that's really old code