libera/#ecl - IRC Chatlog
Search
15:13:26
yitzi
::notify jackdaniel I responded to ed hooks PR comments, but I am also online if you want to talk live.
15:14:10
Colleen
jackdaniel: yitzi said 44 seconds ago: I responded to ed hooks PR comments, but I am also online if you want to talk live.
15:15:08
jackdaniel
I'm fine with strictly following the spec too, it is not that the user can't whip my-package:editor function for fancy things
15:16:05
jackdaniel
but in that case: 1) what does it mean to edit a function? ; 2) we should enforce that by calling check-type in #'ed before DOLIST
15:18:21
yitzi
The idea of using ed to edit a class definition is just too cool. Shame that is excluded in the spec.
15:18:28
jackdaniel
that's fine, we have source location information available. that said I don't think we do anything with it ed-wise (do we?); perhaps that's another area that could be extended. that said it's fine if it is not part of this pull request, but then ed-external should return nil (it does that now I think)
15:20:14
jackdaniel
so we may leave the door open for editing classes whatsoever, but then the documentation should reflect that
15:21:25
jackdaniel
I'd opt then for a "general" behavior with the external editor handling pathnames (and, if you are up to it, looking up for source location of the function - you would then find hints how to do that in swank implementation for ecl)
15:22:05
yitzi
Ok, so what if I fix the documentation to reflect that, remove any restrictions on the type of the argument in this PR. And then investigate finding the source location of non-pathnames in a separate PR?
15:23:19
jackdaniel
sounds great. also mind that the declamation is not right there (I've added a review thread for that in previously)
15:24:21
jackdaniel
great, I will be offline now. sadly I've cought myself that the only way to do something useful in a reasonable pace is to ifconfig eth0 down