Search
Tuesday, 29th of November 2022, 12:14:07 UTC
12:45:32
consolers
the c-wrapper.h for e.g. is significantly different when dumped by different lisps not just whitespace
12:45:48
consolers
maybe investigating why would give a clue.
14:48:31
Bike
anyone know where BF is defined? is it obsolete now?
14:59:56
Bike
looks like the answer is it was removed in may (e1f57e1), so anyting still using it must be dead
16:14:27
drmeister
Hey - I don't want to hear any criticism of dippin' dots. It's the ice-cream of the future.
16:15:14
drmeister
And unlike nuclear fusion (hopefully) it always will be.
16:15:36
drmeister
ACTION loves dippin' dots
16:16:31
drmeister
Nothing says summer like cryogenically frozen ice-cream freezing to the inside of my mouth.
16:17:45
Bike
looks like things work with %s
16:21:14
Bike
so that covers all the BF( in include/. then there's a bunch more in src/, and it looks like a lot more in cando.
18:09:11
Bike
yitzi: if i want us to include more -W in builds generally, should i edit the list in units.lisp, or is there a better place?
18:09:53
Bike
relatedly, looks like we're not doing great with -Wimplicit-fallthrough
18:10:35
yitzi
units.lisp is the place. If you want to make them optional then probably add stuff to configure.lisp
18:22:37
Bike
oh awesome, putting in this warning revealed a subtle bug in the VM
18:24:59
yitzi
I'm all in favor of more warnings.
18:25:35
Bike
yeah, there's no break; in the clause for the keyword parser. only in the long mode, which is why we haven't seen it
18:33:01
Bike
and i think clasp_stringMatch is broken with respect to backslashes
18:33:10
Bike
i think it's only used in pathname parsing, so i guess that wouldn't come up?
18:36:32
Bike
in the case for \, the intent is presumably for it to treat the next character literally, so it falls through to the non-special-character matching case
18:36:47
Bike
but it doesn't actually change the pattern character being used, so it'll test the string against \
18:37:35
Bike
https://github.com/clasp-developers/clasp/blob/main/src/core/lispStream.cc#L3962-L3964 no idea what this is supposed to be, either
18:37:55
Bike
i guess that should be fallthrough
18:38:21
yitzi
huh. Shouldn't the escaped characters just appear literally, including backslash?
18:40:18
Bike
i'm guessing that the pattern string "\a" should match the string "a" but not "\a"
18:40:22
yitzi
oh...thats in the component matcher.
18:40:22
Bike
to match "\a", the pattern would be "\\a"
18:43:38
Bike
but as the code is written now, i think "\a" will match "\a" and not "a", and also "\bc" will match "\c"
18:44:00
Bike
anyway i think i've fixed that and all the implicit fallthrough now
18:47:03
Bike
i'll try throwing in some more -W as i can
18:47:26
Bike
-Wall gave me a bunch of junk warnings unfortunately
18:55:07
Bike
and i guess i can also try removing some of the -Wno- we have
18:57:11
Bike
huh, i actually get no complaints if i remove -Wno-expansion-to-defined
19:01:41
yitzi
I copied those literally from waf. I didn't try to determine if they were needed.
19:03:29
Bike
i figured they were copied from somewhere or another
19:03:39
Bike
and i will have to try them on mac as well of course
19:03:52
Bike
implicit-fallthrough is the main one i want, since i've screwed that up a few times
19:29:49
Bike
-Wdeprecated-declarations would definitely be good so we don't get blindsided by llvm or the system again
19:43:08
Bike
i'm gonna see about putting in -Wall and then blocking any we actually don't want.
19:44:28
Bike
reorder-ctor is pretty pedantic
19:53:41
Bike
ah geez we have uninitialized variables
19:56:23
Bike
infinite recursion in asttooling... oh dear...
20:00:43
Bike
if i turn on -Wall, I need to disable 14 individual classes of warnings to build without any warnings. not great.
20:47:38
Bike
accessible_memory_p looks pretty suspicious.
20:50:13
Bike
add_dynamic_library_impl looks really broken, hopefully we aren't using it
20:51:47
Bike
ahh we're totally using it.
21:11:28
Bike
yitzi: if i add to cflags in units.lisp, those will also apply when building cando, i'm guessing?
21:13:01
Bike
so that's more cleanup in my future. ah well
21:19:33
Bike
there's some code in here that looks like it's looking for a dump-module declaration?
21:22:51
Bike
every time i do something like this it's like going into a house's basement after leaving it for five years
21:23:27
yitzi
Don't get bit by the creepy spiders.
23:02:47
Bike
down to only like twenty unused variable warnings now. guh.
Wednesday, 30th of November 2022, 0:14:07 UTC