libera/#clasp - IRC Chatlog
Search
19:24:44
drmeister
Bike: We should be able to get rid of LambdaListHandler_O - can you point me to what you are looking at?
19:26:37
yitzi
Well, its already a sequence of loads. The issue is whether there are different features present. That is what distinguishes stages (in addition to potentially being a subset).
19:28:31
drmeister
Bike: give me a sec and I'll try removing the TEMPLATED_FUNCTION_VariadicFunctor classes that refer to LambdaListHandler
19:28:43
drmeister
This: `class TEMPLATED_FUNCTION_VariadicFunctor< RT(*)(ARGS...), Pols, clbind::pureOutsPack<PUREOUTS...>,LambdaListHandler> : public core::BuiltinClosure_O {`
19:29:02
drmeister
The LambdaListHandler template parameter was there to help us transition away from LambdaListHandler_O.
19:32:09
drmeister
https://github.com/clasp-developers/clasp/blob/vm-boehm/include/clasp/clbind/function.h#L125
19:32:25
drmeister
And this one... https://github.com/clasp-developers/clasp/blob/vm-boehm/include/clasp/clbind/function.h#L195
19:33:26
drmeister
https://github.com/clasp-developers/clasp/blob/vm-boehm/include/clasp/clbind/function.h#L396
19:33:51
drmeister
A few day ago we were using those classes when I was debugging the bytecode wrappers.
19:34:50
drmeister
So I duplicated those two classes and added a separate template parameter - either `LambdaListHandler` or `Simple`
19:35:13
drmeister
Then I made bytecode wrappers work with `Simple` - you see those classes right after the ones I said you can delete.
19:35:29
drmeister
Notice - they don't use Frame or LambdaListHandler_O - that's because they are called from bytecode wrappers.
19:36:00
drmeister
I kept both classes for the time being so I could switch back and forth to debug it.
19:36:18
drmeister
You are now removing those vestigal, useless template classes. We keep the `Simple` ones.
19:42:59
Bike
toggling that did not work because it tries to include wrappers_methoids.h instead, except that file doesn't exist
19:44:14
Bike
the stuff i pushed to the vm-sans-interpreter branch builds fine. i'm just trying to cut more now, and that's not working
19:44:47
drmeister
I know - I'm using it already - but since we don't have compile-file for bytecode I'm rethinking my options.
4:29:38
Bike
i mean, i know there's the implicit "this" parameter, but other than that it should be the same, right?