libera/#clasp - IRC Chatlog

12:03:32 yitzi drmeister: I've added the cando regression tests to the testing workflow on cando-developers/cando. You can run the cando regression tests with `ninja -C build cando-test`

13:00:30 yitzi Bike: #1349 is ready for review. Put a some explanation of the logic in the PR comments.

14:57:14 drmeister Hello

14:58:17 yitzi Hi!

17:15:02 yitzi Bike: I think the logical pathname are getting mangled in `llvm-sys:create-file` and the usage of `llvm::DIFile`. The logic there seems to assume physical paths with `/` separators.

17:18:32 Bike the logic in DIBuilder::createFile?

17:20:16 yitzi Meant the usage of createFile. Specifically make-file-metadata.

17:22:05 yitzi https://github.com/clasp-developers/clasp/blob/aba76e80d3074243241031829ac0dd5486ffd50d/src/lisp/kernel/cmp/debuginfo.lisp#L110-L123

17:22:07 Bike ahh, i see. good, that's a lot more fixable

17:23:09 yitzi I am making an attempt at it. Basically, not using the directory field at all and just shoving the whole namestring into the Filename

17:24:36 yitzi Found that while using STEP the returned pathnames for the frame stack was things like `/src/lisp/kernel/....` vs `sys:src;lisp;kernel;...`

17:26:11 Bike maybe we could check if the pathname is logical (i think (typep pathname 'logical-pathname)?) and choose a separator appropriately, if sticking everything in the file field doesn't work

17:27:03 yitzi Yes, that would make sense. The only obstacle might be if a physical pathname has a host or a device component?

17:27:05 Bike oh, or actual directory-namestring itself screws it up

17:27:20 Bike (directory-namestring #P"SYS:SRC;LLVMO;DEBUGINFOEXPOSE.CC") => "/SRC/LLVMO/"

17:27:35 yitzi Yeah....not good.

17:28:33 Bike maybe we can just change that. it looks like on sbcl directory-namestring on a logical pathname keeps the ; separators.

17:28:48 Bike (checking because pathnames are an area of the standard i'm less familiar with)

17:29:14 yitzi I am changing the corresponding `getPath` function so that it checks for an empty directory string. `(directory.empty()) ? filename : (directory + "/" + filename);`

17:30:15 yitzi Hopefully that will work if some other code creates `llvm::DIFile` and actually uses the directory slot.

17:30:55 yitzi Does SBCL keep the host is directory-namestring?

17:31:02 yitzi s/is/in/

17:31:02 Bike no.

17:31:45 yitzi That would make it difficult. We wouldn't know what logical host the DIFile is pointing to.

17:32:35 Bike maybe we could use enough-namestring instead of directory-namestring?

17:33:13 Bike except i guess that kind of works in the opposite direction

17:33:49 yitzi Well, maybe not using the Directory slot will work. Fingers crossed.

17:47:49 yitzi That seems to work, although something is still shoving a `/` in front.

18:08:32 kpoeck Hello

18:10:15 yitzi Hi kpoeck. If you are building from recent main you'll need to delete build, dependencies and src/lisp/kernel/contrib/ before you rerun koga. Just FYI.

18:11:40 kpoeck Thanks for the info. Strangely enough it seem to have worked without that.

18:11:57 kpoeck not sure if I should do a clean build

18:12:15 yitzi That would be a good idea.

18:13:24 kpoeck well than i will do a clean build, i am looking for trouble

18:13:38 kpoeck i am not looking for trouble

18:15:25 kpoeck other question. the asdf guys seem to use a quite dated clasp for their ci. Do we have an docker image that is regulary updated that we could provide them?

18:17:11 yitzi Yes. https://github.com/clasp-developers/clasp/pkgs/container/clasp

18:18:38 yitzi It builds once a week. Really, it just installs the nightly builds and quicklisp. https://github.com/clasp-developers/clasp/blob/main/docker/clasp/Dockerfile

18:19:53 kpoeck that should be fine

18:23:36 yitzi Let me know if they need other stuff installed or any requests at all. I can change it anytime.

18:29:53 kpoeck In asdf there is sometimes - e.g. with ecl - like (if (version<= "2.21" tag) ... Do we have a version number that can be used for that? My (lisp-implementation-version) returns now "cclasp-boehmprecise-1.0.0-307-g3cb638c40-cst", perhaps not so extremly helpfull

18:33:30 yitzi Isn't there a software-version? ....

18:33:31 kpoeck and -i can still meta-dot to something defined in lisp, but not to lisp-implementation-version .

18:34:16 kpoeck The entry in TAGS is LCC_RETURN wrapped_cl__lisp_implementation_version_ 14382,915337, is that kosher? Didn't Bike reported something similar?

18:35:31 yitzi I think so...not really sure though.

18:35:57 yitzi `(software-version)` => `"1.0.0-312-gaba76e80d-g85e94b2d"` for cando.

18:36:35 yitzi For clasp it should return something like `""1.0.0-312-gaba76e80d-g85e94b2d"`

18:56:25 kpoeck does the 312 mean something?

18:57:18 kpoeck the version_number comes from (version configuration) i assume, but where is that calculated?

18:57:42 yitzi The number of commits since the "1.0.0" tag. Its git describe.

18:59:45 yitzi Its coming from here: https://github.com/clasp-developers/clasp/blob/aba76e80d3074243241031829ac0dd5486ffd50d/src/koga/units.lisp#L271-L277