Search
Sunday, 17th of February 2019, 7:36:57 UTC
7:47:43
Shinmera
Can't cherry pick, it seems they completely rewrote git history and qtbase is now detached from the original repo
7:50:11
Shinmera
hierarchy is also different
9:13:17
phoe
https://github.com/Shinmera/qt4/commit/cb7ee2421968ded2f3f5ef00e90fe0c854f97613
9:13:17
Colleen
github.com/Shinmera/qt4/com... Website (HTML), Title: QWidgetTextControl: allow context menu to open for a QTextEdit with Q… · Shinmera/qt4@cb7ee24 · GitHu
9:14:28
no-defun-allowed
i don't have anything useful to say, but was no one thinking when they made the Q_Q (probably) macro?
17:38:56
phoe
Shinmera: let me know when you've rebuilt qtlibs - I'll want to upgrade and remove the workaround from qui
17:39:00
phoe
for now, I'll keep on using it though
17:52:12
Shinmera
i know, that's literally what we already decided yesterday
17:52:40
phoe
yep - I just wanted to stress that I'm waiting for it
18:00:54
phoe
Shinmera: about overrides, it doesn't seem like CALL-NEXT-METHOD or CALL-NEXT-QMETHOD works
18:01:24
phoe
CALL-NEXT-METHOD errors with no next method, and CALL-NEXT-QMETHOD doesn't call the next override, it just drops down to the basic qmethod
18:03:23
Shinmera
read again what I told you to do
18:03:29
Shinmera
you need to pass the method name
18:06:26
phoe
And, whenever I override, I need to pass that method name to all overrides, and then use CALL-NEXT-METHOD in all but the deepest call?
18:08:44
Shinmera
"pass it" is the wrong term, it's not a function call. You specify it in the override definition
18:09:25
Shinmera
alternatively you can just, uh, not define-override and instead defmethod
18:09:39
Shinmera
for all but the topmost
18:09:55
phoe
topmost, you mean, the one that gets called last?
18:10:03
phoe
the one that's deepest in the call chain?
18:10:17
Shinmera
the one that does define-override
18:12:06
phoe
sigh, now I gotta make yet another PR to fixed-qtextedit to also include the GF name
18:12:26
Shinmera
you could not include it and just defmethod on the one it generates
18:12:38
Shinmera
not pretty, but it works
18:17:47
phoe
the thing is, I need to export it from qui anyway
18:18:05
phoe
so I may as well export something that doesn't begin with a percent sign
Sunday, 17th of February 2019, 19:36:57 UTC