Search
Saturday, 16th of February 2019, 22:40:59 UTC
23:10:26
phoe
annnnd yet another PR to qtools-ui
23:14:25
Shinmera
I feel like qt bugs should be fixed in, well, qt
23:14:35
Shinmera
rather than workarounds be published.
23:14:38
phoe
the fix is a one-liner IIRC
23:15:07
phoe
yes, https://bugreports.qt.io/browse/QTBUG-9592?focusedCommentId=142931&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-142931
23:15:08
Colleen
bugreports.qt.io/browse/QTB... Website (HTML), Title: [QTBUG-9592] Disappearing popup menu in QPlainTextEdit - Qt Bug Tracker
23:15:12
Shinmera
if you want you can pr against shinmera/qt4 and I'll publish new binaries whenever I can be bothered to
23:15:21
phoe
this IF and RETURN should be removed methinks
23:15:43
Shinmera
it doesn't even link to the commit that fixed it
23:15:58
Shinmera
there's a commit id, but that commit id doesn't exist on the git repo
23:16:02
Shinmera
so I don't know wtf that even is
23:16:42
phoe
https://github.com/qt/qtbase/commit/88a8deea86fe6
23:16:42
Colleen
github.com/qt/qtbase/commit... Website (HTML), Title: QWidgetTextControl: allow context menu to open for a QTextEdit with Q… · qt/qtbase@88a8dee · GitHub
23:17:04
phoe
should I make a PR, or are you able to cherrypick it?
23:17:29
Shinmera
Ah, I searched this, which I guess doesn't work https://github.com/qt/qt5
23:17:29
Colleen
github.com/qt/qt5 Website (HTML), Title: GitHub - qt/qt5: Qt5 super module
23:17:39
phoe
looks like a diffrent repo
23:17:44
phoe
it's past midnight here, take it easy
23:17:59
Shinmera
you can pr if you want, either way works for me
23:18:24
phoe
well, okay, I'll do it tomorrow
23:18:34
phoe
at any point, today is enough coding for me
23:18:41
Shinmera
whoever wakes up first I guess
7:47:43
Shinmera
Can't cherry pick, it seems they completely rewrote git history and qtbase is now detached from the original repo
7:50:11
Shinmera
hierarchy is also different
9:13:17
phoe
https://github.com/Shinmera/qt4/commit/cb7ee2421968ded2f3f5ef00e90fe0c854f97613
9:13:17
Colleen
github.com/Shinmera/qt4/com... Website (HTML), Title: QWidgetTextControl: allow context menu to open for a QTextEdit with Q… · Shinmera/qt4@cb7ee24 · GitHu
9:14:28
no-defun-allowed
i don't have anything useful to say, but was no one thinking when they made the Q_Q (probably) macro?
Sunday, 17th of February 2019, 10:40:59 UTC