Search
10:19:50
phoe
I've come here to ask for a review on https://github.com/Shinmera/array-utils/pull/2
10:19:51
Colleen
github.com/Shinmera/array-u... Website (HTML), Title: Add VECTOR-POP-{FRONT,POSITION}* by phoe · Pull Request #2 · Shinmera/array-utils · GitHub
10:24:59
Shinmera
phoe: why do you return two values? None of the other functions do this
10:25:30
phoe
Likely a leftover from our discussion at #lisp
10:25:39
Shinmera
also wouldn't shiftf already return the value we want
10:26:09
phoe
It would, yep, so the prog1 is unnecessary
10:26:12
Shinmera
so it'd be just decf+shiftf
10:28:54
Shinmera
heh, uses its own ad-hoc thing even