Search
20:21:42
Shinmera
|3b|: Can you verify this? https://github.com/Shinmera/mmap/issues/7
20:21:43
Colleen
github.com/Shinmera/mmap/is... Website (HTML), Title: Invalid file handle opening to write on Windows10 · Issue #7 · Shinmera/mmap · GitHub
20:25:57
|3b|
yeah, same here on win 8.1
20:31:49
|3b|
seems to fail in create-file-mapping
20:36:24
|3b|
translate-protection-flags is suspicious
20:37:11
|3b|
should https://github.com/Shinmera/mmap/blob/master/windows.lisp#L198 also have :exec ?
20:37:12
Colleen
github.com/Shinmera/mmap/bl... Website (HTML), Title: mmap/windows.lisp at master · Shinmera/mmap · GitHub
20:38:08
Shinmera
mh, flagp triggers if all of the flags are contained,
20:38:19
Shinmera
even if there's superfluous tags
20:38:22
|3b|
i mean there are 2 :write clauses
20:38:37
Shinmera
yeah that's probably it
20:38:49
|3b|
and compared to :Read clauses, first looks wrong
20:38:56
|3b|
doesn't seem to help though
20:39:25
|3b|
ACTION continues reading docs
20:39:42
Shinmera
What do you mean, 'first looks wrong'?
20:40:22
|3b|
https://github.com/Shinmera/mmap/blob/master/windows.lisp#L198-L199 is 'first'
20:40:22
Colleen
github.com/Shinmera/mmap/bl... Website (HTML), Title: mmap/windows.lisp at master · Shinmera/mmap · GitHub
20:40:41
|3b|
compared to https://github.com/Shinmera/mmap/blob/master/windows.lisp#L202-L203
20:40:41
Colleen
github.com/Shinmera/mmap/bl... Website (HTML), Title: mmap/windows.lisp at master · Shinmera/mmap · GitHub
20:40:54
Shinmera
why would that be wrong?
20:41:21
|3b|
it returns -execute- when :exec wasn't passed
20:41:40
Shinmera
well yeah that's what you mentioned before and what I already pushed a fix for
20:41:40
|3b|
and never returns page-readwrite
20:42:06
|3b|
ok, conversation got out of sync then :)
20:42:39
|3b|
but i still get error even with fix :/
20:43:03
Shinmera
Oh hey, ql release is finally out. messagebox, file-attributes, zippy, and most of the cl-mixed/harmony updates are now out.
20:45:54
|3b|
ok, "access is denied" from create-file-mapping
20:46:59
|3b|
it did create the file though, but didn't resize it
21:00:13
|3b|
adding :read to :open seems to make it work though
21:00:37
Shinmera
since mmap on windows always requires read.
21:00:49
Shinmera
question is: is this a user error or should we 'help' by implicitly adding read?
21:01:06
|3b|
which i guess makes sense since it is page_readwrite
21:01:58
|3b|
or at least notice the problem and complain
21:02:27
Shinmera
I'd aim for the latter personally. Erroring is typically better than doing things the user might not want.
21:03:29
|3b|
well, making code that worked on linux work on windows without changes is also nice
21:09:36
|3b|
either is OK with me though, as long as it is obvious how to fix it when it breaks if it doesn't help
21:09:51
Shinmera
right. I'll worry about it tomorrow