Search
Saturday, 16th of February 2019, 19:45:59 UTC
20:55:25
phoe
If I have a Qtools class hierarchy FOO, BAR, BAZ, and I define overrides for all three of those
20:55:50
phoe
Can I use CALL-NEXT-QMETHOD in each override to call the next method?
20:56:13
phoe
Let's suppose (define-widget a (qtextedit) ()) (define-widget b (qwidget a) ()) for example
20:56:49
phoe
and I want to define overrides for context-menu-event
20:59:47
Shinmera
I don't know, but as qtools defines overrides as methods, you can pass the same method name and use call-next-method as usual until the top one.
21:00:15
Shinmera
I would wager that the answer is no, though
21:01:25
phoe
Shinmera: okiedokie, I'll try it
23:10:26
phoe
annnnd yet another PR to qtools-ui
23:14:25
Shinmera
I feel like qt bugs should be fixed in, well, qt
23:14:35
Shinmera
rather than workarounds be published.
23:14:38
phoe
the fix is a one-liner IIRC
23:15:07
phoe
yes, https://bugreports.qt.io/browse/QTBUG-9592?focusedCommentId=142931&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-142931
23:15:08
Colleen
bugreports.qt.io/browse/QTB... Website (HTML), Title: [QTBUG-9592] Disappearing popup menu in QPlainTextEdit - Qt Bug Tracker
23:15:12
Shinmera
if you want you can pr against shinmera/qt4 and I'll publish new binaries whenever I can be bothered to
23:15:21
phoe
this IF and RETURN should be removed methinks
23:15:43
Shinmera
it doesn't even link to the commit that fixed it
23:15:58
Shinmera
there's a commit id, but that commit id doesn't exist on the git repo
23:16:02
Shinmera
so I don't know wtf that even is
23:16:42
phoe
https://github.com/qt/qtbase/commit/88a8deea86fe6
23:16:42
Colleen
github.com/qt/qtbase/commit... Website (HTML), Title: QWidgetTextControl: allow context menu to open for a QTextEdit with Q… · qt/qtbase@88a8dee · GitHub
23:17:04
phoe
should I make a PR, or are you able to cherrypick it?
23:17:29
Shinmera
Ah, I searched this, which I guess doesn't work https://github.com/qt/qt5
23:17:29
Colleen
github.com/qt/qt5 Website (HTML), Title: GitHub - qt/qt5: Qt5 super module
23:17:39
phoe
looks like a diffrent repo
23:17:44
phoe
it's past midnight here, take it easy
23:17:59
Shinmera
you can pr if you want, either way works for me
23:18:24
phoe
well, okay, I'll do it tomorrow
23:18:34
phoe
at any point, today is enough coding for me
23:18:41
Shinmera
whoever wakes up first I guess
Sunday, 17th of February 2019, 7:45:59 UTC