Search
10:19:50
phoe
I've come here to ask for a review on https://github.com/Shinmera/array-utils/pull/2
10:19:51
Colleen
github.com/Shinmera/array-u... Website (HTML), Title: Add VECTOR-POP-{FRONT,POSITION}* by phoe · Pull Request #2 · Shinmera/array-utils · GitHub
10:24:59
Shinmera
phoe: why do you return two values? None of the other functions do this
10:25:30
phoe
Likely a leftover from our discussion at #lisp
10:25:39
Shinmera
also wouldn't shiftf already return the value we want
10:26:09
phoe
It would, yep, so the prog1 is unnecessary
10:26:12
Shinmera
so it'd be just decf+shiftf
10:28:54
Shinmera
heh, uses its own ad-hoc thing even
10:30:01
Shinmera
alright, if the tests pass this looks good to me
10:32:00
phoe
and the tests pass on my machine
10:32:51
phoe
https://plaster.tymoon.eu/view/925#925
10:32:51
Colleen
plaster.tymoon.eu/view/925#... Website (XHTML), Title: - Plaster
10:32:57
phoe
can't see the newly added tests there, one second
10:33:16
phoe
I didn't add them to the define-test array-utils
10:34:02
Shinmera
I'll rewrite this for parachute later, don't sweat it
10:37:47
phoe
well, the tests pass anyway
10:37:54
phoe
but they aren't active when you run your test suite