freenode/#sbcl - IRC Chatlog
Search
18:10:23
|3b|`
looks like 27f36d4decfe336b95c8ae63c12ac4c5959671f3 "Impart consistency to accessing thread-local Lisp vars from C"
18:12:39
|3b|`
possibly due to SetSymbolValue that didn't get renamed to write_TLS inside #ifdef LISP_FEATURE_WIN32
18:13:09
dougk
|3b|`: correct, can you try changing to "write_TLS(THRUPTION_PENDING, T, p)" and let me know ?
18:16:29
dougk
ah, see, so my commit message was right - sometimes people used "SetSymbolValue" when they meant "SetTlSymbolValue" and vv, but they're really the same thing; and I got confused trying to unconfuse it
18:28:06
dougk
I attributed the fix to you. It didn't fail for me as I only test on linux, and by "test" I mean compile, never actually run w/safepoint
18:54:29
dougk_
cold-init is able to succeed on x86-64 with both immobile and dynamic spaces mapped at "wrong" addresses now.
19:28:42
scymtym
dougk_: the macos build fails for all configurations: e.g. https://ci.cor-lab.org/job/sbcl-master/2444/ . maybe this is just our slave running old software again
19:33:16
dougk_
there's no (extern-alien ) in make-target-2-load. Any chance you can see what happens if you #+nil out the call to shake-packages?
19:34:33
scymtym
i can't easily get to the machine from here but i can try that tomorrow. alternatively, if that helps at all, you should be able to download the partially build workspace at https://ci.cor-lab.org/job/sbcl-master/featureset=1,label=MAC_OS_mavericks_64bit/ws/*zip*/MAC_OS_mavericks_64bit.zip
20:47:52
|3b|`
(let ((a (delete-duplicates b))) (declare (ignore a))) -> ; caught STYLE-WARNING: The return value of DELETE-DUPLICATES should not be discarded.
20:50:30
dougk_
it's saying that you need to *actually* put its return value somewhere, not just pretend to
20:50:57
|3b|`
ACTION just added that to get rid of the extra warning, real code just had a dead variable
20:52:08
|3b|`
ACTION reads it as saying "don't call delete-duplicates for side effects" rather than "store the result and use it"
20:53:32
|3b|`
discarding the result is fine per spec, as long as you also don't have any expectations of the contents of input list
20:56:51
|3b|`
right, not non-conformant, just seems less than obvious what it means in that case, since it might not be obviously discarded in more complex code (aside from the possible unused variable warning without IGNORABLE)
1:58:27
stassats
dougk_: i think i would want fun headers for assembly routines anyway, for tail calling assembly routines