freenode/#sbcl - IRC Chatlog
Search
4:11:41
aeth
last time I had to deal with intervals in a program I removed overlaps, though, so that's why I overlooked that
4:23:14
aeth
that and (list (list (typep most-positive-fixnum 'fixnum) (typep most-positive-fixnum 'bignum)) (list (typep (1+ most-positive-fixnum) 'fixnum) (typep (1+ most-positive-fixnum) 'bignum)))
4:34:45
aeth
well, unless I'm mistaken, these are integer intervals that must be closed (so my number line analogy is a bit wrong, but the intuition applies as long as they're non overlapping afaik)
4:35:32
aeth
where I'm thinking there might be mistakes if you're not careful in thinking about this is negative-bignums and positive-bignums are on either side of fixnums.
4:50:34
no-defun-allowed
That's why I'm using interval comparisons to decide on the value of the "cheap" case, and how we got here.
7:42:29
stylewarning
Isn’t this the wrong way to be comparing fixnums and floats? https://github.com/sbcl/sbcl/blob/master/src/code/numbers.lisp#L763
9:01:20
no-defun-allowed
Okay, I've finished implementing the transforms, and they look like they work. Should I send a pull request, or something like that?
10:15:39
no-defun-allowed
Sent an email with a patch, but then I tested my interpreter, and the transform makes it consistently slower; so now I don't know if it's a good idea.