freenode/#clim - IRC Chatlog
Search
12:29:52
jackdaniel
scymtym: are you interested in issues I find in backported features or should I keep them to myself?
12:34:15
scymtym
jackdaniel: thank you for the offer. i would definitely like to hear about problems and put them in my TODO list. however, i can't guarantee that i will address everything as quickly as possible since part of the motivation for working in a separate repository was to not have to perform quality control for a wider user base
12:35:18
jackdaniel
one issue: 1) :width and :height for the application are ignored when scrollbars and borders are not present (after the wrap/unwrap commit)
12:36:16
jackdaniel
second: 2) gestures for command arguments are pushed, so translators order is reverse (i.e if you have both arguments marked as :gesture :select, then the first "click" will fill the second argument first)
12:36:54
jackdaniel
and there is this thing Xach reported with limited set of recognized keyword gesture names, but I gather that it was a concious decision
12:40:07
scymtym
yeah, with the last one, i went against the spec a bit since keyword gestures are supposed to be backend-specific, but i think it makes more sense to canonicalize them. not allowing unknown ones is an experimental intermediate step
12:56:18
jackdaniel
assigning decreasing priorities seems to do the trick to enforce a particular order
12:58:33
jackdaniel
speaking which, a gesture may be a list with keyword arguments, i.e :gesture '(select :priority 3), the generator doesn't seem to handle that (possibly it is not a new problem)
13:07:24
scymtym
i haven't look at this in a while, but could the problem be :gesture '(select :priority 3) vs. :gesture (select :priority 3)?
13:09:08
jackdaniel
ah, no, the priority is handled correctly (realized that after trying to construct the test case)
13:21:27
jackdaniel
scymtym: the wrong order of translators was due to this typo: https://github.com/scymtym/McCLIM/blob/master/Core/clim-core/commands/commands.lisp#L147
13:24:08
scymtym
yes, something must be wrong there. but i wonder how it could work at all. maybe i didn't write tests for those parts
13:30:18
scymtym
it "worked" by very strange accident until three arguments with :gesture were supplied. ok
15:36:57
jackdaniel
scymtym: shouldn't this be (when stream-sr-p …) ? https://github.com/scymtym/McCLIM/blob/master/Core/clim-core/panes/stream-panes.lisp#L475
16:04:06
scymtym
sounds useful for clouseau. for something like INSPECT-IN-NEW-OR-EXISTING-INSPECTOR-FRAME