freenode/#clim - IRC Chatlog
Search
13:46:20
scymtym
jackdaniel: i think i replied to all unresolved discussions in 865. this is minor and i don't want to introduce further confusion in the web interface, but it seems like you didn't actually make the "vertice -> vertex" change
15:39:11
scymtym
unrelated: a bit of progress with the "dark theme" work: https://techfak.de/~jmoringe/mcclim-dark-theme-1.ogv
15:40:02
jackdaniel
to clarify the performance thingie, you want me to add bunch of macrolets to remove (defmethod foo (a b) (foo b a)) where applicable?
15:42:43
scymtym
i thought there was only one instance. in that instance, yes, that is my suggestion (with or without MACROLET, i'm not sure). if we are talking about the same code, the change i am suggesting would reduce the number of methods from four to two
15:45:59
scymtym
the change you proposed would remove two methods, thus reducing the original four methods to just two. my suggestion would also result in two methods, the difference being that the method would "symmetric" instead of one delegating to the other
15:48:31
jackdaniel
scymtym: please take a look at the last commit (I've made it separate), does this solve this discussion?
15:54:27
scymtym
jackdaniel: looks good. nitpick: THUNK is usually used for zero-argument continuations
15:59:34
jackdaniel
scymtym: do you prefer rename of angle-contains-*-p to be squashed into "move math utilities" commit or to have it as a standalone one?
16:01:28
jackdaniel
and there is this remark about something belonging to a different commit, but I don't understand it
16:06:43
scymtym
ok, final attempt: the commit "geometry: move math utilities to a separate file" removes the REGION-DIFFERENCE STANDARD-LINE STANDARD-RECTANGLE method. the commit message says "remove duplicated methods calling difference-segment/polygon". i think this would better fit into the "cleanup: region-intersection: remove duplicated methods" commit