freenode/#clim - IRC Chatlog
Search
8:59:25
jackdaniel
I want to merge changes iteratively, because this module has plenty of methods and it is easy to get lost (especially if everything comes in one go)
10:04:32
scymtym
jackdaniel: with refactor-regions, i get a new test failure: MCCLIM.REGIONS.REGIONS.ELLIPSE: (REGION-CONTAINS-POSITION-P EL 301 101) returned the value T, which is true
10:43:28
jackdaniel
fact that we factor epsilon for testing in polar coordinates doesn't make it more stable (but rotated ellipse rendering in clx depends on that)
11:34:14
scymtym
jackdaniel: i just ran the branch in Jenkins and this test failure was new compared to master. i didn't look into it further
13:25:13
jackdaniel
scymtym: as I've expected "regressions" come from the fact, that we have slightly bigger epsilon; we can change (in this example) 301 to 303 and 101 to 103 and it will succeed. the problem is that rotated ellipse rendering relies on such epsilon as it is now
13:26:19
jackdaniel
we can do one of the following: fix the region-contains-position-p for ellipses and have rendering broken or adjust tests to account for a larger epsilon
13:26:45
jackdaniel
I hope to fix rendering later down the path but doing it now will only introduce mess
13:41:27
jackdaniel
scymtym: I've just pushed to mitigate another rounding error and to make reported failures better to read
13:42:04
jackdaniel
(instead of flet I've put there macrolet, so we can see actual parameters in a test)