freenode/#clim - IRC Chatlog
Search
14:15:28
jackdaniel
scymtym_: it is put in a single and for a reason: you don't want to have four reports when the issue is with rounding (in case of ellipses it is indeed rounding issue, i.e 14.99999 vs 15 -- their representation is suboptimal). I think that a helper function will be better indeed.
14:18:09
scymtym_
i would want four reports with offending values instead of just NIL, but that may be personal preference
14:18:31
scymtym_
putting the whole pattern into a helper function will make changes easy in any case
14:30:57
jackdaniel
first canonicalize radii to orthogonal vectors and represent elliptical thing as vectors aligned with xy + ellipse rotation. I haven't tried it yet, but I have hopes that it will give more accurate results and will be easier to work with
14:31:18
jackdaniel
for point belonging we can always transform the ellipse to polar coordinates (or even retain such transformation)
14:32:36
scymtym_
ok. i would generally like us to move towards zero expected failures so we can automate test execution and failure detection better
14:33:06
jackdaniel
me too, but it is better to have tests which show existing defects than not have them
16:02:54
beach
scymtym_: I did some experimentation, and I think I can really make the new Clouseau work for my bootstrapping objects. Thanks for all the hard work on it.
16:04:51
scymtym_
beach: i'm really glad to hear that. please share some screenshots when you get it working
16:09:16
jackdaniel
scymtym_: is there something else you want me to do before this branch gets merged?
16:13:14
scymtym_
jackdaniel: i don't want to dwell on the tests too much, but indentation seems off again in the final commit. also, many of the LET bindings seem unnecessary after the introduction of HAS-VALID-BOUNDING-RECTANGLE
16:18:51
scymtym_
did we decide which merge policy we want to use ("just merge" vs "rebase, then merge")?
16:23:39
jackdaniel
since we are at pull requests, do you mind looking at https://github.com/sharplispers/clx/pull/152? (it is small)