freenode/#clim - IRC Chatlog
Search
12:42:23
ck_
it was a shot-from-the-hip commit to see whether this approach is maybe fundamentally stupid from a different perspective
12:46:51
ck_
maybe, but your comments are still valid, it's just that an overarching ruling might make the whole thing obsolete
12:47:54
ck_
Well, we can have a discussion on the github page, that's what it is there for, right? Kicking the ball around a bit
13:23:57
scymtym
that seems confusing. if 2048 is the maximum request size, why compare the image width and height to it? maybe +X11-IMAGE-DIMENSION-LIMIT+ (taking inspiration from ARRAY-DIMENSION-LIMIT)?
13:27:38
ck_
Yeah sorry, I got the names mixed up there, jd's name for the reason was still reverberating
13:30:49
ck_
so yeah, the maximum request length is a "CARD16", that's their name for a 16 bit unsigned int. Length of what exactly though? A square image just below the size that got rejected by the current code is already 2^22 pixels
13:32:27
scymtym
are there multiple restrictions in play? i don't know much about the X11 protocol either
13:34:30
ck_
Maybe I'll research this another time, for now I have more pressing matters to attend to ... lunch
13:36:22
jackdaniel
it could be that I've mixed up things and 2048 triggers another issue (not the "too big of a request" one)
13:36:40
jackdaniel
and this issue could have been present only on some X11 builds because i.e it was the xserver bug
13:37:54
ck_
I didn't try removing the safeguard, am afraid of graphics glitches and trusted the previous developer that visited the code
13:49:43
scymtym
ck_: now that i look at the code again, one PUT-IMAGE call (the one in COMPUTE-RGB-MASK) has arguments :bitmap-p nil which the other lacks. you probably have to preserve this
13:53:59
ck_
scymtym: ... or maybe not, if you take a look at the function. There's no difference between the calls actually.
13:54:24
scymtym
also, am i reading this wrong or does clx already have code for splitting putimage into multiple requests? taking into account DISPLAY-MAX-REQUEST-LENGTH and everything
13:55:15
jackdaniel
I've mentioned that. This splitting doesn't work when a single scanline does not fit in the max request length