Search
Tuesday, 8th of January 2019, 19:08:34 UTC
19:09:32
Inline
oh no no, i didn't find anything with word wrapping wrong
19:10:23
Inline
i just changed my Apps/Listener/listener.lisp s class definition to use :end-of-line-action :wrap in the pane definition fields
19:10:44
Inline
:end-of-page-action i didn't even mention i think
19:16:38
Inline
http://dpaste.com/3TMDFV7
19:17:21
Inline
you can find it there and some other changes which get applied upon load
19:22:48
Inline
ohh ok, now i got what a pull request is
19:23:13
Inline
and for that i would have to have diffs on the changes i made
19:23:47
Inline
and also, what should be my model, i don't want to fork, so i suppose i'd have to use share based pull request
19:27:48
Inline
oh ok, i got the diffs via git diff hehe
19:41:46
Inline
this all comes down to me not being trained in git
19:43:26
Inline
so i can view the difference between local and remote master vie git diff, but how would i push my changes ? all at once ?
19:43:44
Inline
anyway, nope i'm not gonna do that
19:44:19
Inline
like i told i'm pretty new to git actually, and i don't have the workflow/routine with it
19:47:34
Inline
so basically i use git add <file> then do a git rebase right ?
20:23:03
jackdaniel
you first do git add file
20:23:10
jackdaniel
you write commit message
20:23:35
jackdaniel
if you have forked to your own repository (you should), then now: git push
20:23:49
jackdaniel
and make a pull request from github interface (on the website)
20:32:58
Inline
i suppose i'm in the middle of forking
20:33:11
Inline
ya i forked McCLIM/McCLIM
20:51:12
Inline
so from which repository do i do the pull request ?
21:21:45
jackdaniel
Inline: thank you. I've reviewed your PR – you need to clean it up from unnecessary changes, fix indentation and split separate changes into commits with commit messages which describe why the change was made (what was wrong and how it addresses the issue)
21:22:04
jackdaniel
please also write down steps how to reproduce the issue
21:46:29
Inline
what does a separate commit mean ?
21:58:20
jackdaniel
Inline: http://try.github.io/ here are resources to learn git
22:15:50
Inline
jackdaniel: how many changes do you make per day ca. ?
22:16:12
Inline
jackdaniel: and how often do you commit and or do pull-requests ?
22:16:31
Inline
well i don't get the workflow that much
22:16:53
Inline
i mean ok you change stuff and commit, so ideally you'd have 1 change per commit or so ?
22:16:54
jackdaniel
what is ca? and how do you count "changes"?
22:17:29
Inline
changes would be like lines inserted/removed
22:17:35
jackdaniel
commits should represent atomic improvements (by atomic I mean: one commit fixes one thing and can't be divided more without)
22:18:16
Inline
so these conversation threads on which you comment on my changes for example are those all commits ?
22:18:34
Inline
i think i'm confusing stuff
22:19:13
jackdaniel
as of number of lines, to day for instance I have changes which count around 250 lines, but it is a very poor way of measuring things
22:19:30
jackdaniel
best commits remove unnecessary lines without removing functionality
22:19:50
jackdaniel
also often you work whole day towards understanding the problem to change one line
22:20:22
Inline
hmm, i thought referring to the issues i created would be separate commits too
22:20:24
jackdaniel
other times you perform mundane changes which are no brainer (but can't be really automated) and you may get thousands of lines
22:20:37
Inline
so commits you mean as git commands
22:20:56
jackdaniel
git commits are changes which are added to the repository history
22:21:17
jackdaniel
conversation you saw on gitlab is a peer review tool which allows commenting on changes
22:21:34
Inline
so can i reverse the pull-request ?
22:21:42
Inline
or make it undone so to say
22:23:17
jackdaniel
I'm going to sleep now, good night \o
2:05:45
loke
jackdaniel: haven't you ever done a commit that removes lines and adds functionality?
2:06:13
loke
There have been cases where I removed some stupid restriction by simply removing some code.
4:06:28
beach
Good morning everyone!
4:53:51
loke
beach: Do you want to meet up when I come to France net week?
5:04:23
loke
Latest version of Climaxima now contains emebedded documentation
5:04:33
beach
As I recall, you have a weekend free, right?
5:04:37
loke
that kinda sorta makes it useful :-)
5:05:24
loke
I have only two plans for the weekend: 1) To visit the science museum, and 2) To go to a specialised beer shop and buy some local beers to bring back home
5:05:41
beach
Oh, I see, so you are busy.
5:06:18
beach
I was hoping you could come to Bordeaux on Saturday, we have dinner, you stay over night and go back on Sunday. But that won't work, will it?
5:06:43
loke
Well. I have considered Bordeaux, but I'd go on sunday morning and go back in the evening
5:06:55
loke
It's onyl 2 hours train, no?
5:07:17
loke
Then I can get my beer shopping and museuming done on saturday
5:07:30
beach
Sounds good. Then we can have lunch at my place on Sunday.
5:08:02
loke
Wherefrom does the train depart?
5:08:12
beach
From Gare Montparnasse in Paris.
5:08:33
beach
South of the river. West-ish.
5:08:51
beach
I should have said, "left bank"
5:10:11
loke
And how often does the train depart?
5:10:33
beach
Once an hour on weekdays. Sundays I don't know. Let me check the SNCF website.
5:13:26
beach
08:52, 09:52, 10:52, etc.
5:13:42
beach
... for the direct trains, that is.
5:14:02
loke
OK. I'll try to get on the 9-train. That should get me there by 11.
5:15:07
beach
Check first-class prices. Often they are no more expensive than second.
5:17:10
beach
59€ one way in first class.
5:18:10
beach
The return is way more expensive.
5:18:54
beach
Probably because people are returning to Paris for a week of work after a nice weekend in Arcachon. :)
5:20:16
beach
The 17:04 is 99€ in second class.
5:21:42
beach
I don't suppose 50€ difference is important to you.
5:35:20
loke
What's the difference between the classes? :-)
5:35:46
beach
A bit more room in first. Wider seats. Also fewer kids, so quieter.
5:35:50
loke
I'm not rich enough that I don't care about 50€ :-)
5:37:08
beach
Time for a break. Back in 30 minutes.
6:06:30
beach
The 17:08 takes a bit longer but is much cheaper if that matters.
6:06:58
loke
Do you know if they have Internet access on the train?
6:07:22
beach
In first class they do. Don't know about second. I always go first.
6:09:35
loke
beach: THen I will take first. I will likely spend most of my spare time during this trip to work on Climaxima :-)
6:10:17
loke
If you want to try the latest version, it's available in the usual place. It now has documentation :-)
6:10:58
loke
I've also fixed a million documentation errors in Maxima itself. They god annoyed with my posting patches so I have commit rights there now. :-)
6:11:11
beach
OK. Today I am a bit busy. My favorite coauthor is coming over for lunch. Our normal schedule is on again after the holidays. So I have to work on our papers, fix lunch, clean up, work again.
6:11:35
loke
Favourite? What about all the other coauthrors? Do you really hate them that much? :-)
6:11:41
beach
I think Climaxima could be one of the "killer app"s for McCLIM, but I think I have said that before.
6:12:28
beach
I learned this trick from my wife, who calls me "the best husband she ever had". :)
6:19:48
krwq
beach: lol, i usually say to my son he is my favourite son too :D
6:20:29
beach
loke: When you know your time of arrival, please let me know. Also if you have a phone number that works in France, it might be good to give it to me, say by email. And you should let me know if you have any food restrictions.
6:21:28
beach
loke: Oh and the car number you are in. I'll be on the platform waiting for you.
6:41:50
loke
beach: I don't eat meat :-)
6:41:55
loke
beach: I eat fish though
6:57:30
loke
I eat it, but I'm not a fan of it :-)
6:59:03
loke
krwq: I have two daughters, and when they fight I say: “don't say that to your favourite sister”
6:59:37
beach
So it's a widespread idea. Good to know.
Wednesday, 9th of January 2019, 7:08:34 UTC