Search
Tuesday, 8th of January 2019, 15:07:04 UTC
15:07:07
jackdaniel
you can't have two panes rendered with different backends on the same frame
15:09:04
mgiraud
jackdaniel: *enlightment* thanks
16:04:46
Inline
uhuh, my changes seem to have also deleted the window-splitting thing somehow, oh man
16:05:12
Inline
i mean that's good but i didn't expect that...
16:11:32
Inline
i mean if that was the case why didn't it happen yesterday.... meh
16:12:49
Inline
i started and restarted my sbcl several times and in between also deleted the whole fasl cache directory
17:39:52
jackdaniel
now that I have word wrap and other bugs sorted out I'm tempted to split lines by word with minimum raggedness
18:10:05
jackdaniel
http://i.imgur.com/FjuYQ04.png
18:10:13
jackdaniel
on the top: maintaining baseline
18:10:45
jackdaniel
on the bottom left: greedy word wrap, on the right: character wrap
18:17:55
Inline
ja end of page action :wrap is really not that useful
18:18:10
Inline
no idea what would use it
18:19:33
Inline
maybe a drawing application which draws randomly in space without regards to being in finite space area ?
18:20:19
Inline
so in that case when it gets over the page it's morrored bottom-up or some such
18:20:39
Inline
s/morrored/mirrored/ meh
18:20:59
jackdaniel
that sounds unlikely
19:05:10
jackdaniel
Inline: if you found a seemingly correct solution please make a pull request. also please include detailed steps how to reproduce the issue from empty lisp image
19:08:02
Inline
wait jackdaniel, what is a pull request ?
19:08:28
Inline
I just updated my comments, the markdown is what i did not know before
19:09:32
Inline
oh no no, i didn't find anything with word wrapping wrong
19:10:23
Inline
i just changed my Apps/Listener/listener.lisp s class definition to use :end-of-line-action :wrap in the pane definition fields
19:10:44
Inline
:end-of-page-action i didn't even mention i think
19:16:38
Inline
http://dpaste.com/3TMDFV7
19:17:21
Inline
you can find it there and some other changes which get applied upon load
19:22:48
Inline
ohh ok, now i got what a pull request is
19:23:13
Inline
and for that i would have to have diffs on the changes i made
19:23:47
Inline
and also, what should be my model, i don't want to fork, so i suppose i'd have to use share based pull request
19:27:48
Inline
oh ok, i got the diffs via git diff hehe
19:41:46
Inline
this all comes down to me not being trained in git
19:43:26
Inline
so i can view the difference between local and remote master vie git diff, but how would i push my changes ? all at once ?
19:43:44
Inline
anyway, nope i'm not gonna do that
19:44:19
Inline
like i told i'm pretty new to git actually, and i don't have the workflow/routine with it
19:47:34
Inline
so basically i use git add <file> then do a git rebase right ?
20:23:03
jackdaniel
you first do git add file
20:23:10
jackdaniel
you write commit message
20:23:35
jackdaniel
if you have forked to your own repository (you should), then now: git push
20:23:49
jackdaniel
and make a pull request from github interface (on the website)
20:32:58
Inline
i suppose i'm in the middle of forking
20:33:11
Inline
ya i forked McCLIM/McCLIM
20:51:12
Inline
so from which repository do i do the pull request ?
21:21:45
jackdaniel
Inline: thank you. I've reviewed your PR – you need to clean it up from unnecessary changes, fix indentation and split separate changes into commits with commit messages which describe why the change was made (what was wrong and how it addresses the issue)
21:22:04
jackdaniel
please also write down steps how to reproduce the issue
21:46:29
Inline
what does a separate commit mean ?
21:58:20
jackdaniel
Inline: http://try.github.io/ here are resources to learn git
22:15:50
Inline
jackdaniel: how many changes do you make per day ca. ?
22:16:12
Inline
jackdaniel: and how often do you commit and or do pull-requests ?
22:16:31
Inline
well i don't get the workflow that much
22:16:53
Inline
i mean ok you change stuff and commit, so ideally you'd have 1 change per commit or so ?
22:16:54
jackdaniel
what is ca? and how do you count "changes"?
22:17:29
Inline
changes would be like lines inserted/removed
22:17:35
jackdaniel
commits should represent atomic improvements (by atomic I mean: one commit fixes one thing and can't be divided more without)
22:18:16
Inline
so these conversation threads on which you comment on my changes for example are those all commits ?
22:18:34
Inline
i think i'm confusing stuff
22:19:13
jackdaniel
as of number of lines, to day for instance I have changes which count around 250 lines, but it is a very poor way of measuring things
22:19:30
jackdaniel
best commits remove unnecessary lines without removing functionality
22:19:50
jackdaniel
also often you work whole day towards understanding the problem to change one line
22:20:22
Inline
hmm, i thought referring to the issues i created would be separate commits too
22:20:24
jackdaniel
other times you perform mundane changes which are no brainer (but can't be really automated) and you may get thousands of lines
22:20:37
Inline
so commits you mean as git commands
22:20:56
jackdaniel
git commits are changes which are added to the repository history
22:21:17
jackdaniel
conversation you saw on gitlab is a peer review tool which allows commenting on changes
22:21:34
Inline
so can i reverse the pull-request ?
22:21:42
Inline
or make it undone so to say
22:23:17
jackdaniel
I'm going to sleep now, good night \o
2:05:45
loke
jackdaniel: haven't you ever done a commit that removes lines and adds functionality?
2:06:13
loke
There have been cases where I removed some stupid restriction by simply removing some code.
Wednesday, 9th of January 2019, 3:07:04 UTC