freenode/#clim - IRC Chatlog
Search
7:08:41
jackdaniel
loke`: what's up? (next time ask the question right away, now I'm curious and you may not be there ;-)
7:35:14
jackdaniel
slyrus: I've looked into the `:borders` initarg issue, check out the pull request
7:36:26
jackdaniel
I think that we want more systematic solution given the origin of the problem (also recently someone else has bumped onto that from the other side: tried to pass :scroll-bars for theirs pane subclassing application pane)
7:58:22
slyrus
jackdaniel: I'm not sure I follow what you're getting at. The :borders nil thing definitely seems bogus to me and we should fix that immediately. The larger issue I don't feel like I understand well enough to weigh in yet.
7:59:18
slyrus
Some knucklehead writes in an annotation on application-pane in the spec: "Is there somewhere in the spec where the superclasses of application-pane are listed? In McCLIM, it is a subclass of clim-stream-pane, but it doesn't seem that the spec says that this has to be the case."
8:00:24
slyrus
Earlier on in the page it says: "Most CLIM stream panes will be subclasses of this class."
8:17:54
jackdaniel
I'm getting at that this PR just solves your immediate problem while I think we have more systematic issue which is very much possible to solve
8:20:05
jackdaniel
it wouldn't be non-conforming if application-pane would not subclass clim-stream-pane, but a) why wouldn't it, b) even if it doesn't, what does it matter?
8:22:32
jackdaniel
right now the helper macro which creates a panes uses make-clim-*stream-type*-pane if the name is a keyword being a member of (:interactor :application :pointer-documentation), otherwise it simply uses make-pane
8:24:56
jackdaniel
I'm aiming at that make-clim-stream-pane should be used for all pane types which denote streams (and imho even if they are not, we could use this function - that't give us some additional perks)
8:26:20
jackdaniel
so the minimal solution is to remove also `:scroll-bars` from initargs (it shouldn't do a thing anyway, because scroll-bars are not part of stream-pane in light of the spec)
8:28:21
jackdaniel
preferable solution is do the minimal solution, remove the slot scroll-bars and improve do-pane-creation-form to create all panes which are issued as symbols with make-clim-*-pane