Search
5:26:21
beach
Good morning everyone!
6:44:01
jackdaniel
currently our make-space-requirements asserts, that <= 0 min-width width max-width (and similar for height)
6:44:18
jackdaniel
I think we should clamp values instead
6:44:42
jackdaniel
example: sometimes we compbine space requirements where component knows only its minimal width/height
6:45:10
jackdaniel
so let's say, we call space-requirement-combine with only min-width set to 100
6:45:29
jackdaniel
with other space requirement, where min-width is 0, width is 1 and max-width is +fill+
6:46:02
jackdaniel
result of such combination is min-width=100, width=1, max-width=+fill+, what leads to assertion dropping us in the debugger
6:46:35
jackdaniel
imho this should be adjusted if these criteria can be met like: min-width=100, width=100, max-width=+fill+
6:46:49
jackdaniel
(because these space requirements are essentially compatible)
6:47:28
jackdaniel
or we could enforce that in the combine function
6:47:37
jackdaniel
either way, I don't think we should error on such occasions