freenode/#clim - IRC Chatlog
Search
10:43:54
scymtym
jackdaniel: in the refactored code, the traversal (that is calling the inferior producer) does not stop at already seen objects
10:45:07
jackdaniel
I was trying to make the refactored alorithm semantically identical;it seems that I've failed at that
10:45:30
scymtym
re #1074: wouldn't it be better to handle the dx=0 ∧ dy=0 situation in the arrow drawing code instead?
10:46:01
scymtym
i discovered the graph formatting regression while putting the commented-out graph tests in graph-formatting.lisp into a demo file
10:46:35
jackdaniel
that's why I've suggested in the comment - namely that maybe the caller should be responsible for detecting invalid data
10:46:54
jackdaniel
and atan* to signal an error (to make the issue explicit when invalid data sneaks in)
10:47:28
scymtym
yeah, i'm pretty sure if dx=0 ∧ dy=0 comes up, you can't draw a "normal" arrow anyway
10:57:04
scymtym
jackdaniel: https://github.com/McCLIM/McCLIM/pull/1075 is a draft pull-request that shows how i found the problem. should i remove everything but the regression fix from the pull-request?
11:00:44
jackdaniel
I would also add tests if they are complete, but I'd keep the formatting changes from it
11:02:07
scymtym
the tests are only tests in McCLIM's demo/test sense, but separating them out makes sense to me and, as i said, in this case, the tests demonstrated the regression
11:02:42
jackdaniel
re pointer drawings in the pointer documentation -- I think that it is a good idea, however I would draw more "symbolic" versions of the mouse (i.e three rectangles with one in an "active" colors for the button press, two triangles with one active for scrolling etc -- so a) more symbolic, b) different for different gestures, not from the same template
11:03:30
jackdaniel
sure, I agree that having them in the third column in demodemo is a good idea, and they should go with the same PR as the regression fix