freenode/#clim - IRC Chatlog
Search
7:34:40
jackdaniel
I see some minor problems with how we find a port, but changing it will be backward-incompatible, so I'll leave it be
7:37:07
scymtym
jackdaniel: could you squash removing and re-adding of pointer grabbing into a single commit, preferably as the first commit of the pull request? i think that would be easier to follow and work better with git tools
7:40:31
jackdaniel
ugh, I'd rather not but OK. I'll split the commit removing it as well, to make changes atomic
7:41:36
scymtym
thank you, i really find it confusing right now because something is removed at the beginning and then added back in a different form at the very end
8:07:50
scymtym
i just realized that we had two subtly different versions of the WITH-POINTER-GRABBED macro
8:24:28
scymtym
i have resolved all conversations (i think. github for sure doesn't make it easy to tell) and was going to ask whether everything was ready
9:21:57
scymtym
jackdaniel: looks good. one final thing: could you change the message of the new commit to something like "with-pointer-grabbed: remove unused macro" or something else that gives a reason for the removal
9:46:52
scymtym
right. shouldn't "ports: refactor port-grab-pointer protocol" and "pointer grab removal" happen in a single commit, then
11:18:55
scymtym
jackdaniel: i'm sorry that i didn't notice this earlier, but the description text in the demo should use (format … "…line ~<newline>…") instead of (format … "…line~<newline>…"). otherwise the first word of the next is fused with the last word of the previous line