Search
Thursday, 21st of March 2019, 20:53:42 UTC
4:06:54
beach
Good morning everyone!
7:43:20
loke
Researching the presentatio history stuff is fun :-)
7:45:21
loke
Well, because apparently (if I am to believe the comments) it's underspecified:
7:45:36
loke
https://github.com/mcclim/McCLIM/blob/clipboard2/Core/clim-core/presentation-defs.lisp#L557
7:46:51
jackdaniel
as I said in the pull request comment: if there is no need to make presentation-history-* generics please don't
7:47:08
jackdaniel
and if there is such a need, all functions in a group should be generic, not only the one which you need
7:48:12
loke
Also this: https://github.com/mcclim/McCLIM/blob/clipboard2/Core/clim/input-editing-drei.lisp#L167
7:48:34
loke
jackdaniel: Yes. I'm taking that to heart, and doing more research first before proposing anything.
7:49:22
loke
I'm experimenting with implementing an alternative presentation history class altogether. That should, at least in theiory, be possible as far as I can tell.
7:50:02
loke
So for now, the PR is dead. :-)
7:50:19
loke
I'm not closing it yet, because I was to tkeep the comments for reference.
7:51:02
jackdaniel
they won't disappear if you close it. if you keep it please add tag [draft] so nobody will merge it by accident
7:52:22
loke
Hmm... Github has support for draft PR's, but it seems as though you can't downgrade a PR to draft. Only the other way around.
7:53:57
jackdaniel
just add [draft] in pr title
7:54:18
loke
Nah. I just closed it :-)
8:43:12
jackdaniel
I'm going to postpone page alignment feature for much later because I'll never get out of this rabbit hole
Friday, 22nd of March 2019, 8:53:42 UTC