freenode/#clim - IRC Chatlog
Search
18:12:51
jackdaniel
slyrus1: these changes look good to me. if nobody tests it before I'm done with my own cleanup I'll take care of it.
18:15:37
slyrus1
Great. There's one more PR for fixing rotated text on the PDF backend that I just added as well.
18:19:28
slyrus1
that's for scigraph, which specifies the rotated text. The new one are PDF backend changes that make the rotated text work properly there.
18:19:51
slyrus1
For better or worse, I've been trying to keep the PDF, PS, and scigraph changes independent of each other.
18:20:54
slyrus1
And the comment about the bitmap rotation is just sort of old/wrong. We don't need rotated bitmaps for rotated/transformed text on PDF, PS, or mcclim-freetype backends.
18:21:21
slyrus1
the #+nil'ed out code can probably just go away. but I'll get to the scigraph stuff once the PDF and PS changes land.
18:21:24
jackdaniel
as of medium-draw-text, my changes involve removal of this custom "transformation" argument
18:55:00
slyrus1
ah, but without your patch there is no with-drawing-options (medium :transformation transformation) form.
18:57:00
jackdaniel
(merged-transform (clim:compose-transformations native-transform medium-transform))
18:58:01
slyrus1
I can see how that should work, but this will require changes to multiple backends when it lands. For the moment, my code is "correct". Let's fix the things that break when yours lands so I can test it.
18:59:04
slyrus1
The PS backend uses the same logic as the PDF backend. Happy to fix them both when the time comes.
19:00:56
jackdaniel
but if you insist then the answer is similar to the previous PR, looks fine but I'd want someone to test it (could be me if nobody is up to that)
19:11:49
jackdaniel
I'm cutting through some bullshit abstraction in raster extension to unify it with patterning code
19:23:25
slyrus1
Ok, if I adopt your change in replay-output-record (and add (with-drawing-options (medium :transformation transformation) ...)) (and pass nil as the transformation parameter to medium-draw-text*) then things seem to work properly.
19:26:08
slyrus1
Ok, great. Do you want to merge my PDF and PS backend changes on your branch before everything lands? I'm happy to work off your branch for the moment.
19:26:09
jackdaniel
also I think that rotation didn't work with raster backend since it always uses native truetype
19:34:07
slyrus1
how about if we add the with-drawing-options (medium :transformation transformation) on master? shouldn't break anything.
19:35:23
slyrus1
then I can use (medium-transformation ...) in the PDF and PS backend code and code that expects a working transformation in the transformation argument will still work (until it goes away with your branch).
19:36:51
slyrus1
sure, but they're easily resolved and it moves three pieces of code in the right direction.
19:37:36
jackdaniel
maybe let's do it this way: branch off form said commit, apply your changes there, and I'll try to rebase on your branch, hm?
19:39:02
slyrus1
and I'm happy to see things done that way and the PDF and PS backends can easily be adapted to work with that, but without that commit I need what's in the transformation argument.
19:39:47
jackdaniel
slyrus1: that's why I'm suggesting for you to branch from this commit and give me url to your branch
19:40:21
jackdaniel
or we could wait with ps/pdf until this week ends, if I'm not ready by then I'll fix the conflicts aposteriori
19:42:30
slyrus1
or we could just land my PDF and PS changes and deal with the trivial merge that will happen when your branch lands :)
19:49:07
jackdaniel
sure, still I want someone to test that before merging. that will be either Nisar or loke