Search
Tuesday, 24th of March 2020, 9:35:36 UTC
14:11:51
Colleen
drmeister: kpoeck said 6 hours, 15 minutes ago: no problems with slime and regression-test, please read log for detailed answer. Would also be great to know if the error comes from a "read-from-string", since I might be missing to bind (eclector.reader::*backquote-in-subforms-allowed-p* in read-from-string
14:15:20
drmeister
::notify kpoeck Within slime - when I (setf eclector.reader::*backquote-in-subforms-allowed-p* t) then I am able to load the regression-tests;run-all.lisp
14:15:20
Colleen
drmeister: Got it. I'll let kpoeck know as soon as possible.
14:16:14
drmeister
Here is the report...
14:16:16
drmeister
https://www.irccloud.com/pastebin/ByBIspx8/
14:45:03
kpoeck
drmeister your report is that with newest clasp and parallel compiler?
14:45:03
Colleen
kpoeck: drmeister said 29 minutes, 43 seconds ago: Within slime - when I (setf eclector.reader::*backquote-in-subforms-allowed-p* t) then I am able to load the regression-tests;run-all.lisp
14:49:18
kpoeck
Would it be possible to get the precise test where you get the backquote error
14:54:34
kpoeck
I am also amazed that the test "describe-alltogether" fails (https://github.com/clasp-developers/clasp/blob/dev/src/lisp/regression-tests/environment.lisp#L186)
14:55:09
kpoeck
Could you just execute the with-output-to-string and see with which object the describe fails?
14:55:14
Bike
uhh. yeah, that's kind of impressive
14:56:21
Bike
i've been working on my computer so i'm not logged in
14:57:46
Bike
nope, error. "Could not find the class DESCRIBE-CLASS"
14:58:20
Bike
oh, but that's defined in the file, right
14:58:24
Bike
let me just run all the regression tests
15:01:11
Bike
nope, that one passes for me.
15:01:45
Bike
"unexpected failures (SBCL-CROSS-COMPILE-4 INCLUDE-LEVEL-2B INCLUDE-LEVEL-3 TEST-CHAR-2A TEST-CHAR-3A TEST-CHAR-4A TEST-CHAR-5A TEST-CHAR-6A TEST-CHAR-7A TEST-CHAR-8A TEST-CHAR-9A TEST-CHAR-10A TEST-CHAR-11A)"
15:18:39
kpoeck
Do I believe drmeister has not all latest code
15:28:45
kpoeck
Wanted to write: I do believe drmeister does not use latest dev
15:30:20
kpoeck
e.g. he might not have: https://github.com/clasp-developers/clasp/pull/942
16:50:47
cracauer
I think drmeister is on a branch for llvm10 and merges dev manually.
16:51:13
drmeister
Hi I have a branch that works with a very recent version of llvm-tot.
16:51:24
drmeister
I merge dev into it periodically.
17:07:11
kpoeck
drmeister so your problem with eclector.reader::*backquote-in-subforms-allowed-p* might be been solved already
17:33:36
drmeister
kpoeck: Why do I see the problem with eclector - am I using the wrong commit?
17:33:58
drmeister
Oh - you said it above. Things are crazy here.
17:34:09
kpoeck
Are you using the parallel compiler?
17:34:12
drmeister
I'm like a frog - I only see things that are moving in my field of vision.
17:34:17
drmeister
Yes. Parallel compiler always.
17:34:54
kpoeck
When you merge. do you merge whoöe dev or do you do cherrypicking?
17:35:10
drmeister
I'm using 'dev' here.
17:35:31
kpoeck
latest commit or are you behind?
17:35:45
drmeister
My 'dev-llvmtot' branch is not in play at the moment - I'm not using it here.
17:36:40
drmeister
Pretty up to date - I just pulled the latest - only src/lisp/regression-tests/misc.lisp changed.
17:37:40
kpoeck
that were the regression-tests for the slime thing
17:39:30
drmeister
I'm rebuilding from scratch.
17:40:34
kpoeck
Ok, lets see how that goes
17:42:52
drmeister
Do I need a different commit of eclector?
17:43:55
drmeister
My branch of Eclector is 34 commits behind master and can be fast-forwarded.
17:44:01
drmeister
This is what is in wscript... 66cf5e2370eef4be659212269272a5e79a82fa1c
17:44:30
drmeister
And it is the commit that Eclector in my system is currently set to.
17:46:05
drmeister
The Eclector repository is: 66cf5e2370eef4be659212269272a5e79a82fa1c
17:46:18
drmeister
This: https://github.com/robert-strandh/Eclector.git
17:50:39
drmeister
So I think eclector is out of date in clasp and I should bring it up to the latest commit.
17:50:46
Bike
well, i see relevant commits since 66cf5e2
17:50:55
Bike
"Quasiquote and unquote are allowed by default" for instance
17:51:20
Bike
it sounds like kpoeck has been building with a newer eclector fine
17:52:46
drmeister
Trying the latest commit: fe80b66ac38abdb65cbc24948c1bb241cd69edbf
17:53:10
drmeister
Requires: ./waf update_dependencies
17:54:07
drmeister
Requires a bit more - AssertionError: Could not find waf node for lisp file src/lisp/kernel/contrib/Eclector/code/readtable/condition-reporters-english - did you run './waf update_dependencies'?
17:56:29
drmeister
We have tools-for-build/regenerate-cleavir-file-list.lisp - I use that I presume.
17:57:04
Bike
it turns the ASDs into the file list we actually use
17:57:30
drmeister
Ah - but clasp needs to be built to run it and I can't build clasp without it fixed.
17:57:35
drmeister
I'll hand edit the files
17:57:43
drmeister
Then run it once clasp is back up.
17:59:37
Bike
maybe we could load the regenerator from sbcl instead
18:00:10
drmeister
Yes - I can build bboehm
18:09:33
kpoeck_
Drmeister: i have build clasp with a newer eclector with 1 change
18:10:14
drmeister
What is that one change?
18:10:15
kpoeck_
If you wait a bit, i can send a pr!
18:10:46
drmeister
Is it a change that requires the latest Eclector?
18:11:11
kpoeck_
The treatment of `#’, in eclector
18:12:15
kpoeck_
No its a change for eclector. Am sitting in a bus to home, please give me 30 minutes to arrive
18:16:34
drmeister
In asdf... #+clasp (cleavir-env:optimize (cleavir-env:optimize-info CLASP-CLEAVIR:*CLASP-ENV*))
18:16:38
drmeister
That kills that idea.
18:23:06
Bike
asdf is using cleavir-env?
18:23:20
drmeister
I'm adding some shims
18:24:11
drmeister
loading regenerate-cleavir-file-list.lisp into bclasp
18:25:11
Bike
why is asdf accessing cleavir env? i don't see that in my copy
18:28:49
drmeister
Ok - phew - I thought we had another problem.
18:28:54
drmeister
We do need to get rid of that.
18:29:03
drmeister
or #+cclasp and another for #+bclasp
18:29:22
drmeister
https://www.irccloud.com/pastebin/JYSuPVyX/
18:29:30
drmeister
To regenerate-cleavir-file-list.lisp
18:30:44
drmeister
Yeah we need it - the changes are quite extensive.
18:30:45
drmeister
https://www.irccloud.com/pastebin/TUAlUuko/
18:31:17
Bike
well, 66cf5e2 is from last may
18:31:44
drmeister
Running regenerate-cleavir-file-list.lisp with bclasp works.
18:32:10
drmeister
And cclasp is building now with the new eclector.
18:32:41
drmeister
Check the logs for the last couple of minutes.
18:32:48
drmeister
I'm building cclasp with the new eclector now.
18:33:27
kpoeck
I did build clasp with newest eclector
18:33:35
kpoeck
in a local branch I have
18:33:37
drmeister
I'm going to need a macpro in my house going forward. The speed of this imacpro is great.
18:33:57
kpoeck
but there is - or there was - one problem,
18:34:10
kpoeck
https://github.com/s-expressionists/Eclector/issues/59
18:34:51
drmeister
Yeah - problems suck!
18:35:06
drmeister
kpoeck: Where does that go?
18:35:32
drmeister
Yeah - I hit a big problem.
18:35:36
drmeister
Ok - where do I put that?
18:36:24
kpoeck
In https://github.com/s-expressionists/Eclector/blob/master/code/reader/macro-functions.lisp#L323
18:36:45
kpoeck
put waht I put in the ticket
18:36:54
kpoeck
But I did all that already!
18:37:08
drmeister
I'm a little uncertain how to pull this all together though.
18:37:16
Bike
wait, so what is the problem
18:37:24
Bike
if newest eclector has a fix for this issue already
18:37:58
kpoeck
scymtym was nwilling to put the fix
18:38:11
drmeister
I have local changes here to upgrade eclector and I've updated other things.
18:38:29
Bike
Oh, so it should be :keep :keep instead of :keep t?
18:38:39
kpoeck
I also have local changes to upgrade eclector :-)
18:38:43
drmeister
What is the best course of action. I have upgraded eclector and I have fixed and run regenerate-cleavir-file-list.lisp
18:39:07
kpoeck
I did the same, so this is fine
18:39:35
kpoeck
Where should we put the "patched" eclector
18:40:07
kpoeck
in https://github.com/clasp-developers/Eclector?
18:40:49
drmeister
Oh - so we need a custom patched eclector for :keep :keep ?
18:40:53
kpoeck
Best would obviously to convince scymtym to change it upstream
18:41:35
drmeister
But it's just the :keep :keep rather than :keep t - correct?
18:42:31
drmeister
I made the change and I'm trying it.
18:42:45
drmeister
If this works I'll fork Eclector again.
18:42:48
kpoeck
I compile like 50 systems in quicklisp with that
18:43:24
drmeister
What is the original eclector repo?
18:43:38
kpoeck
https://github.com/s-expressionists/Eclector
18:44:28
drmeister
I already have a fork. Is there a way on github to quickly update a fork?
18:44:31
kpoeck
used to be with RobertStrandh
18:44:52
Bike
if you mean update a fork to match upstream? i think you're just supposed to do it normally on your system
18:45:29
kpoeck
But pragmatically I'd nuke your fork and fork it again
18:46:15
kpoeck
from the right place please, from https://github.com/s-expressionists/Eclector
18:47:14
drmeister
And it's building on my system with that change.
18:47:22
drmeister
kpoeck you are a life-saver - thank you very much!
18:50:27
drmeister
Here's the current wscript entry for eclector.
18:50:30
drmeister
https://www.irccloud.com/pastebin/rCp21QZi/
18:52:04
kpoeck
revision 0ec57a718a16af6681e624183e1d6000d1d496d2 looks good
18:52:59
drmeister
I'm going into a phone conference in a few min.
18:54:51
drmeister
I pushed the new clasp 'dev' with updated eclector
19:13:05
drmeister
Building from scratch on my mbp
19:21:34
Bike
so i had a thought about "lambda" in backtraces
19:21:58
Bike
if an anonymous function is in an sbcl backtrace, instead of just 'lambda', it writes '(lambda [lambda-list])'
19:22:05
Bike
we should be able to do thar, right?
19:23:30
Bike
except we do all that computation in C++ so it's a huge pain, ok
21:20:43
kpoeck
unsurprisingly I just build with the newest wscript using newest eclector from clasp-developers (and regression-test give the expected results)
21:20:59
kpoeck
Will update the expected results though
Tuesday, 24th of March 2020, 21:35:36 UTC