Search
Sunday, 9th of February 2020, 19:32:29 UTC
19:33:07
kpoeck
I can drop the load-time-value
19:34:31
Bike
well what i mean is like, is this function going to be called more than once for the same encoding? the hash tables are effectively constant, i would imagine
19:35:16
kpoeck
hash tables are constant, could precalculate
19:36:05
Bike
i don't know how generate-encoding-hashtable is called or anything see
19:38:55
Bike
where is that called from?
19:40:15
Bike
github search is not cooperating.
19:40:47
kpoeck
might be from c++, let me check
19:41:09
kpoeck
For sure it is call from asdf
19:41:29
kpoeck
modules/asdf/ext/asdf-encodings/encodings.lisp
19:42:34
kpoeck
format = eval::funcall(ext::_sym_make_encoding, format);
19:44:37
kpoeck
https://github.com/clasp-developers/clasp/blob/dev/src/core/lispStream.cc#L3286
19:46:43
Bike
so we're building a new hash table every time parse_external_format is called?
19:49:00
kpoeck
can obviously be improved by caching since the tables are constant
19:50:11
kpoeck
like creating a variable with a alist of enconding-names and their hash-tables
19:50:24
kpoeck
encoding-name and hash-tables
19:53:40
kpoeck
(time (compile-file "/Users/karstenpoeck/lisp/compiler/clasp-karsten/src/lisp/kernel/lsp/generated-encodings.lsp")) -> 39.741 secs
19:54:49
kpoeck
on my 8 year old machine
20:15:15
Bike
kpoeck: any way we can do those defstruct/etc tests without digging through macroexpansions? i mean that's less a test of behavior and more a test that we haven't changed the code lately
20:30:17
kpoeck
If there is another way to check that an accessor is redefined?
20:31:26
kpoeck
fboundp will not check that (perhaps I could fmakunbound instead)
20:33:12
kpoeck
or check for a redefinition warning
20:33:54
Bike
should be possible to catch the warning. i think it's stable, since slime relies on it
20:34:32
kpoeck
ok, than I change the test accordingly
20:35:00
Bike
should be... cmp:redefined-function-warning, i think
20:35:36
Bike
might not work outside of compile-file. hm hm
2:20:11
drmeister
When we switch to faso mode - .o files become .faso files and .fasl files become .fasp files. Is this a good idea?
2:20:46
drmeister
An alternative is to keep the .o and .fasl extensions but internally they both get the .faso/.fasp file format.
2:20:52
drmeister
This would work better with ASDF.
2:21:10
drmeister
Alternatively, we change ASDF
2:23:54
drmeister
No - I' changes to ASDF
2:24:37
drmeister
I'm not sure if it requires changes to ASDF.
4:03:10
beach
Good morning everyone!
Monday, 10th of February 2020, 7:32:29 UTC