freenode/#clasp - IRC Chatlog
Search
17:34:57
drmeister
https://github.com/clasp-developers/clasp/blob/dev/include/clasp/clbind/derivable.h#L87
17:35:20
Bike
the isgf offset is also exposed to the compiler for some reason, but that doesn't seem to be used so goodbye
17:40:05
Bike
also, get-funcallable-instance-function doesn't actually return a function, just a pointer. is that actually helpful?
17:42:05
Bike
that makes no sense with how it's used in compile.lsp, though, so that's already broken.
17:59:59
drmeister
Bike: Can you give me a heads up when you update sicl and the sicl hash in wscript and make these funcallable-instance-function stuff.
18:01:04
drmeister
I'll pull, rebuild and build some flame charts that look the the flame charts I posted a couple of days ago.
19:04:41
Bike
i thought of a way that i think would work to be able to "copy" a whole closure into a funcallable instance without needing locks. but it's kind of complicated so i'm just going to leave it in a comment.
19:27:12
Bike
bclasp closures work differently from cclasp ones... so my attempt doesn't work... i think i can figure this out though.
19:27:42
kpoeck
Bike: now that you fixed the thing that allows to compile-file unicode-strings and maintain them, what about https://github.com/clasp-developers/clasp/pull/717
19:28:32
drmeister
Bike - yeah - bclasp closures close over an Environment_O object don't they? But it's an object in one of the closure slots isn't it?
19:30:32
drmeister
There's some fields in the ClosureWithSlots_O C++ class. The closureType field tells you if it's a bclaspClosure and the 0th slot contains that environment.
19:30:54
drmeister
Now I'm puzzled why the length is zero - it should be one and that slot should contain NIL.
19:31:29
Bike
but i'm checking whether the length is zero. so it's basically false unless you put some non-fastgf function in.
19:39:01
Bike
of course if id just skipped to my general solution this wouldn't be necessary. let's see
19:49:03
kpoeck
Is this a message from clasp: Probably a BUG: slot SELFWARD-OPERATION in #<The STANDARD-CLASS ASDF/LISP-ACTION:COMPILE-OP> stopped existing between compile and load
19:49:13
kpoeck
Is this a message from clasp: Probably a BUG: slot SELFWARD-OPERATION in #<The STANDARD-CLASS ASDF/LISP-ACTION:COMPILE-OP> stopped existing between compile and load
19:52:51
Bike
drmeister: i am fairly sure it should be fine to call an instance while another thread is set-funcallable-instance-function-ing it. But calling s-f-i-f on the same instance in two threads simultaneously might be weird. can we mark the body a critical section or whatever?
19:53:21
kpoeck
compiling the file in https://gist.github.com/kpoeck/2b77d621b710f0bb8bc5dbd591905069
19:56:38
Bike
yeah, we should use clasp ffi for tests like that. ...anyway let me see if i can figure out the bug
19:59:07
stassats
since quicklisp is loaded twice, although i would not expect it to load asdf twice too
20:06:03
kpoeck
Well I can make that as a part of "Library tests" if you feel it is weird to do otherwise
20:15:11
selwyn
last time i tried to load trial, it complained about something not being a superclass. but i think you have an issue ticket about that already
20:28:17
kpoeck
Bike: are now all literal strings that are loaded in a compiled-file of type (SIMPLE-ARRAY ...) and no longer SIMPLE-BASE-STRING?
20:29:16
Bike
all i changed is that now strings that aren't base-strings aren't dumped as base-strings
20:29:31
kpoeck
core_float_to_string_free seems to assume that (ext:float-nan-string most-positive-double-float) returns a SIMPLE-BASE-STRING which is no longer true
20:32:01
Bike
oh, well, if you have your read "" as a character string patch, it'll not be a base string any more
20:44:07
kpoeck
In lispworks there is *DEFAULT-CHARACTER-ELEMENT-TYPE*, do we have something like that?
20:53:24
kpoeck
yes, if i set (setq *DEFAULT-CHARACTER-ELEMENT-TYPE* 'character) than (type-of "") returns SYSTEM:SIMPLE-AUGMENTED-STRING
20:54:21
kpoeck
(setq *DEFAULT-CHARACTER-ELEMENT-TYPE* 'base-char) (type-of "") -> SIMPLE-BASE-STRING
20:56:55
kpoeck
so with default-settings (setf (char (copy-seq "AAA") 0) (code-char 256)) fails in lispworks too
22:39:53
drmeister
./waf configure had problems upgrading sicl - so I removed it and then ./waf configure works.
23:23:21
stassats
as i said "if that's the quality of the lisp code what can be said about the whole benchmark?"
23:24:03
karlosz
thanks! that's good news then, because i have other patches that sped my build up more :)
23:24:05
stassats
but i guess it's too much to ask for well written lisp code, but in how many other languages are they not experts?
23:26:19
stassats
and it feels like the exercise in "make a wrong statement on the internet and wait for it to be corrected"
23:26:37
stassats
except for "publish poorly optimized code and wait for someone to prove you wrong"
23:41:31
selwyn
yeah i got that earlier. i thought it went away, but it turns out that i actually built the latest clasp with AST - i just realised
23:43:55
selwyn
could it be due to not having distclean'd? it's what i assumed when i saw it and indeed i hadn't
23:45:56
Bike
https://github.com/robert-strandh/SICL/blob/87eb4fead5c65eaa5b8954ca2f7fa47cf5dd08e8/Code/Cleavir/CST-to-AST/convert.lisp#L17
23:48:21
Bike
it matches the backtrace too, that method is the last function before the error basically
23:51:05
karlosz
this is why i stuck with cherry picking the patches i made - even loading sicl in clisp broke a couple of things recently
23:59:23
Bike
well i was going to make more cleavir changes tomorrow anyway, so i can update it with that
23:59:41
Bike
related, if anyone knows what name i should use for the multiple-value-setq-prog1 thing, now's the time
2:29:53
karlosz
and reinitialize-data on top of the inlining function bar can go away, and so can set predecessors next to inlining-function
2:31:05
karlosz
patch for getting rid of both forthcoming after this build finishes, but its at 90/445 and hasn't died yet
2:31:54
drmeister
My laptop ran out of power in the middle of ASDF build - and it hung up - so I'm starting it again.