freenode/#clasp - IRC Chatlog
Search
22:48:57
scymtym
drmeister: shiho: if i understood correctly, https://github.com/scymtym/language.smarts/commit/b525d52c9925da551c2c8fb264b943d389ffc76f does what you want
22:51:11
drmeister
I need to spend some time with this code tonight and sort out in my head what is going on.
23:05:38
scymtym
drmeister: i thought [C]1 and [C:1] should just be different spellings of the same thing - that is the point of the change
23:07:24
drmeister
scymtym: It's ok -it's kind of a subtle point and requires several readings of the spec to understand what these are.
23:19:48
drmeister
So I think I shouldn't apply the change. I think the parser is fine. I think the problem is all in how we interpret what the parser gives us.
23:20:31
drmeister
I'm still puzzled by [C:1] - I think it means [C&:1] where :1 is always true - it's the side effect that we want, assign a label '1' to that carbon.
23:23:07
scymtym
i expected these labels to turn into AST pointers during or after parsing, so they wouldn't really be "executed" while matching
23:25:02
drmeister
So should I apply these changes? Or keep working with what we have? I confess that I don't really understand the SMARTS parser.
23:38:33
scymtym
i don't think you should apply the changes as they are. the test cases and maybe other parts can be used once it is clear what the parser should do
23:41:06
scymtym
to me, the main problem seems to be that there is no clear path to figuring out what a given syntactic element should mean
23:43:01
drmeister
Well, most of it is fairly clear - it's just these dusty corners. The SMIRKS colon operation is underspecified.