Search
Wednesday, 1st of April 2020, 15:27:23 UTC
17:56:21
Bike
ok got no-source-info instructions from ppcre down to load time values, top level enters and their returns, and two assignments which i don't know what's going on with them
18:23:50
kpoeck
Being april first, i made a pr to support Shinmera s float-features with https://github.com/clasp-developers/clasp/pull/962
18:24:05
kpoeck
Still need to test on linux though
18:24:46
kpoeck
Coudn't find tests, so i wrote my own
18:27:14
Colleen
http://i.imgur.com/EcJ3MfG.gif
18:31:20
kpoeck
I assume parachute would be your test-framework of choice for float-features?
18:39:35
Bike
so this... works? we get SIGFPE consistently?
18:39:50
Bike
i guess i can just build it, eh
19:10:36
kpoeck
I did not dare to activate that globally, since clasp in to many places throws sigfpe
19:10:52
kpoeck
but works fine as used in the test-cases
19:11:40
kpoeck
e.g (flet ((foo () (if (> 10 (random 20)) 0.0 0.0)) (bar () (if (> 10 (random 20)) 23 24))) (ext:with-float-traps-masked () (/ (bar) (foo)) ))
19:12:21
kpoeck
just look at the 8 test cases
19:12:45
kpoeck
and the default is no floating point errors
19:13:37
kpoeck
Did 8 test-cases for float-features with parachute and tested them with clasp, sbcl and ccl
19:16:16
Bike
default is no error. i see.
19:23:06
kpoeck
with :compile-at :execute tests even work in ecl
19:41:06
kpoeck
now build on linux running in virtualbox, that can take some hours
20:11:16
Bike
./waf test works. very nice
20:11:51
Bike
hopefully this will encourage me to actually run the tests
20:13:19
Bike
unexpected successes on what i think are the function name tests from your PR
20:13:41
kpoeck
yes, need to update that
20:14:33
kpoeck
also ansi-tests are now well under 200 failures, we are advancing!
20:15:38
Bike
let's seee... the test-char are the char comparisons... some loop problems... are all the number comparison ones similar to the char comparison problems?
20:18:01
Bike
why is loop-complex-1 a fail? works in the rep
20:18:22
kpoeck
Only fails with some optimize settings
20:18:53
kpoeck
But the loops errors are really errors in the loop macro I believe
20:18:56
Bike
0 is not of type complex, i see
20:19:24
kpoeck
perhaps we can join forces with ecl to fix them
20:20:13
kpoeck
Marius Gerbershagen seems to have a good grap on loop
20:20:55
kpoeck
I reported one of these errors for ecl and he fixed it (and I backported it to clasp)
20:21:47
Bike
some of these i don't even get
20:21:49
kpoeck
I also tried Beach s loop implementation and the errors where all gone
20:22:01
Bike
(loop for i from 1 to 5 for c from #c(0 1) collect c)? what should that do?
20:22:58
kpoeck
(#C(0 1) #C(1 1) #C(2 1) #C(3 1) #C(4 1))
20:23:33
kpoeck
ecl warns nicely that : ;;; Warning: The form #C(0 1) evaluated to #C(0 1), which was not of the anticipated type REAL.
20:24:44
kpoeck
sbcl executes and does not complain, probably their loop is fixed
20:24:56
Bike
hm.... clhs 6.1.2.1.1 just says it should be a number, not a real
20:28:16
kpoeck
Thats why I believe that the loop macro generates wrong code (and clasp complains correctly)
20:28:51
Bike
(loop-check-data-type data-type 'real), that's probably worng
20:29:43
Bike
yeah, if i change that to number it stops complaining
20:31:15
Bike
hm... maybe it ought to check for downto/upto/below/above though
20:31:35
Bike
oh, and by says it has to be a positive number, which implies being real
20:32:13
Bike
though i don't see why "by" needs that restriction... whatever
21:00:58
kpoeck
sbcl loop generates (DECLARE (TYPE NUMBER C)) instead of (DECLARE (TYPE REAL C))
21:01:43
kpoeck
thesame thing you proposed I assume
21:02:09
Bike
yeah but some more thinking might be required for upto and downto and stuff.
21:04:05
Bike
does clear up those tests, though
2:30:05
Bike
so yeah i did the function names thing and also increased the source information coverage in instructions, though it needs a sicl update
2:31:11
drmeister
Or is it still in the works?
2:32:22
Bike
i pushed some changes to clasp and some changes to Cleavir, but I haven't updated clasp's Cleavir commit since that's a bit of a pain
2:32:25
Bike
but i can do that tomorrow
2:57:43
beach
Good morning everyone!
Thursday, 2nd of April 2020, 3:27:23 UTC