freenode/#clasp - IRC Chatlog
Search
16:30:54
drmeister
We had a combination of (cons number number) being passed in to source-pos-info-file-handle and source-pos-info-handle not doing any type checking and then implicitly casting it to a SourcePosInfo_sp pointer. I fixed the latter here and hopefully now it won't segfault and lock up.
16:44:00
Bike
drmeister: ok, so the origin of the instruction is (0 . 17) i.e. wrong, and then source-pos-info is the car of that, zero, which is what i saw before.
16:54:48
drmeister
I pushed my type check for source-pos-info-file-handle and the better workbench-load.lisp file.
17:16:29
drmeister
The source-position generic function now takes the lambda list (client stream) and the method that we define in translate.lisp thinks it takes (stream client)
19:24:41
Bike
it gets to loop-read-and-compile-forms, then within a few anonymous funcalls it hits another bad access
20:09:31
Bike
the frame source info isn't any more specific, so i'm not even sure what function it is in
23:14:52
drmeister
I wasn't convinced that it was the first argument rather than one of the other functions in the function list.
23:16:42
drmeister
Yes - the result of coercing the function-designator or one of the functions in functions.
23:36:04
drmeister
And I'll check fmv - a standard-generic-function can be a function designator - right? Of course it can.
0:37:25
drmeister
Generic functions are instances of FuncallableInstance_O - that inherits from Function_O
1:05:17
drmeister
We should check every call to coerce::functionDesignator and make sure we aren't coercing the result to a Closure_sp
1:06:40
drmeister
I almost always use it for its intended purpose: if ( Something_sp = foo.asOrNull<Something_O>()) {...}
1:25:26
drmeister
I did a survey of every use of asOrNull and there were only half a dozen outside of if expressions.
2:43:35
drmeister
[55 of 434] - that's good - I think it still needs some work to improve the compiler performance - were there improvements still to be made?
3:12:43
drmeister
I set the CST feature in the buildbot build - so I'll get a better time from that.
3:16:01
drmeister
If we can do better - we should - especially while this stuff is fresh in your head.
3:17:47
drmeister
shiftf-rotatef.lsp https://github.com/clasp-developers/clasp/blob/dev/src/lisp/kernel/lsp/shiftf-rotatef.lsp#L41
3:38:13
Bike
it's probably slow partly because it evaluates while compiling which means compiling while compiling