Search
Sunday, 21st of January 2018, 2:16:38 UTC
2:18:51
drmeister
Everything builds - I pushed the changes to dev
3:43:08
beach
Good morning everyone!
6:19:56
drmeister
beach: read-rational in macro-functions.lisp didn't handle negative numbers
6:22:02
drmeister
Now I'm on to this error:
6:22:03
drmeister
https://www.irccloud.com/pastebin/neytjdaf/
6:23:15
beach
That should happen only if you have a backquote in a place that is not allowed. Of course, it could be that I have neglected some such places that ought to be allowed.
6:23:52
drmeister
It's having a problem with this form:
6:23:53
drmeister
https://github.com/drmeister/clasp/blob/cst/src/lisp/kernel/lsp/predlib.lsp#L133
6:24:14
drmeister
The backquote at the bottom: `(OR (RATIONAL ,rat-start ,rat-end) (FLOAT ,real-start ,real-end)))
6:25:02
beach
Looks like it ought to be allowed.
6:29:35
beach
I am more inclined to think it has to do with #+ and #=
6:30:24
drmeister
Why do you think that?
6:30:49
beach
Because I don't have any of those in my code, and I have no problems with my code.
6:30:56
beach
This code contains some of them, though.
6:32:21
drmeister
You mean earlier in the predlib.lsp file?
6:32:24
beach
I confirm that #+hello`(...) is not working.
6:33:00
beach
No, I haven't looked very closely at that file.
6:33:35
beach
I just see some #+ and #-, and I can very well imagine that I omitted to allow backquote inside those.
6:33:43
beach
And I just confirmed that this is the case.
6:34:34
drmeister
How would you recommend I proceed?
6:34:53
beach
I would say wait for me to fix it.
6:34:58
drmeister
I also confirm that #+hello `(1 2 3 4) does not read.
6:35:32
drmeister
It's late here - I'm going submit a pull request for the rational reader.
6:40:06
drmeister
We had a discussion a couple of days ago about cst-read handling eof - is this an acceptable solution for that?
6:40:07
beach
The fix for #+ and #- should be simple. I'll deal with it after I get your pull request.
6:40:08
drmeister
https://www.irccloud.com/pastebin/Gp2XALbv/
6:40:42
beach
This is an old version. You need to pull a new one.
6:41:44
drmeister
Oh dear - it's late to be messing with git - wish me luck.
6:47:00
drmeister
That appears to have worked - I submitted a pull request.
6:51:02
drmeister
Ok - good night - I'll pick up any new changes in my morning.
6:51:27
beach
Good night drmeister.
6:51:42
drmeister
::notify bike bclasp seems rock solid now - no more exception handling problems that I can see.
6:51:42
Colleen
drmeister: Got it. I'll let bike know as soon as possible.
6:53:19
drmeister
::notify bike It was a very, very longstanding problem in the WITH-TRY macro when an exception bubbles up the stack.
6:53:19
Colleen
drmeister: Got it. I'll let bike know as soon as possible.
6:55:37
beach
drmeister: You need to pay more attention when you submit a pull request.
6:55:55
beach
You have a (char= #\-) in there, which is always true.
6:56:07
beach
So the default clause is never reached.
6:56:33
beach
SBCL would tell you that because it says "Deleting unreachable code."
6:57:26
drmeister
Ah - sorry. I checked the output but I didn't give it any case that would test that branch - sorry.
6:58:00
drmeister
And cclasp doesn't delete unreachable code or warn about it.
7:02:27
beach
And you left a FORMAT in there.
7:04:04
beach
Also, there is no need for a newline after COND. It wastes valuable vertical space.
7:04:29
beach
I fixed the backquote problem. It was a matter of wrapping the #+ and #- bodies in with-preserved-backquote-context.
Sunday, 21st of January 2018, 14:16:38 UTC