freenode/#abcl - IRC Chatlog
Search
22:57:43
alandipert
easye so i'm working on combining abcl and abcl-contrib jars together on a classpath via maven, which i *think* would work if i 1) use a custom manifest including the "contrib" section and Implementation-Title, and 2) if abcl-contrib.jar resources were under contrib/*
22:59:10
alandipert
although i'm not sure i'd request changing how abcl-contrib is packaged because it might break people. another thought i had was around here: https://github.com/armedbear/abcl/blob/14eb7dac59e534a9b9ad84cb50a713e5d2ce23dc/src/org/armedbear/lisp/abcl-contrib.lisp#L213
22:59:59
alandipert
in my maven app, `relative-pathname` is nil, but the contrib resources are in the jar, just at the top level (and not under contrib), because maven mushed them in there. so i wonder if nil should be interpreted as /
4:42:24
easye
alandipert: Hmm. I don't think we need to worry too much about breaking existing usage for the "finding contrib" mechanism, as I don't think there is too much usage.
4:43:37
easye
I don't think that we can just use "nil should should be interpreted as /" as that will make that branch always true, right?
4:45:27
easye
If I remember correctly, he whole idea of using the "key as a value" in the manifest was to avoid defining a "non-standard" key that might potentially be stripped out by toolchains that create manifests.
4:47:03
easye
I guess the way forward might be to indeed add another branch in the the toplevel OR with a "non-standard" manifest key for which we parse the value directly, and therefore could easily specify the case in which the contribs are munged in the the top-level.
4:48:07
easye
You probably have a better grip on what would make sense from a manifest compatibility perspective (if any is indeed really needed, which might well be a spurious concern)
4:49:17
easye
Using the top-level directory to find the contrib might try to add the ASDF definitions from ABCL itself in a weird way, so maybe we want a mechanism that explicitly enumerates all the ASDF entries to treat as a contrib?
4:56:16
easye
Explicitly specifying things would prevent the wildcard search in the jar which is pretty inefficient at the moment.